Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No element checking code in submitForm method #81

Closed
aik099 opened this issue Jul 12, 2014 · 2 comments
Closed

No element checking code in submitForm method #81

aik099 opened this issue Jul 12, 2014 · 2 comments
Labels
bug

Comments

@aik099
Copy link
Member

aik099 commented Jul 12, 2014

The submitForm method isn't checking that given xpath belongs to form node.

Related issue Behat/MinkSelenium2Driver#170
@aik099 aik099 added the bug label Jul 12, 2014
@aik099 aik099 mentioned this issue Jul 12, 2014
Merged
@stof
Copy link
Member

stof commented Aug 30, 2014

$crawler->form() will throw an exception on invalid usage, so this is checked already

@aik099
Copy link
Member Author

aik099 commented Aug 30, 2014

How lucky that underlying library does that for us. Here is the link to the code: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/DomCrawler/Form.php#L373

@aik099 aik099 closed this as completed Aug 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stof @aik099