Ensure that "change" event is fired only once per "setValue" call

[aik099]

Current results:

• selectOption for radio: fires 2 times (no manual code, we just call .choose( method, maybe bug in Zombie)
• check : fires 2 times (no manual code, we just call .check( method, maybe bug in Zombie)
• uncheck : fires 2 times (no manual code, we just call .uncheck( method, maybe bug in Zombie)

To be on the safe side I've executed these tests on the PhantomJS and they fail the same way as for Selenium2. So it's something in Zombie that causes change to fired twice. Reported in assaf/zombie#675

Tests added in Behat/Mink#495

[stof]

why talking about PhantomJS ? It has nothing to do with ZombieDriver. It is a Webdriver implementation

[aik099]

Both Zombie and PhantomJS are headless and support JS. I though that for JS support they might be using same libraries. And if a bug, that causes click event to fire 2 onchange events is in that library, then it probably would be broken in both Zombie and PhantomJS.

It turned out that only Zombie does that and PhantomJS does all correctly.

[stof]

They don't use the same libraries at all. PhantomJS uses webkit (through the QTwebkit project, so an old version of webkit) while Zombie implements a browser in NodeJS (based on JSDom for the DOM implementations).
They are not even written in the same language

[aik099]

Relevant test suite output:

7) Behat\Mink\Tests\Driver\Js\ChangeEventTest::testSetValueChangeEvent with data set "radio" ('the-radio-m', 'm')
initial value setting triggers change event
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'1'
+'2'

.../vendor/behat/mink/driver-testsuite/tests/Js/ChangeEventTest.php:150
.../vendor/behat/mink/driver-testsuite/tests/Js/ChangeEventTest.php:48

8) Behat\Mink\Tests\Driver\Js\ChangeEventTest::testSelectOptionChangeEvent with data set "radio" ('the-radio-m', 'm')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'1'
+'2'

.../vendor/behat/mink/driver-testsuite/tests/Js/ChangeEventTest.php:150
.../vendor/behat/mink/driver-testsuite/tests/Js/ChangeEventTest.php:84

9) Behat\Mink\Tests\Driver\Js\ChangeEventTest::testCheckChangeEvent with data set #0 (true)
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'1'
+'2'

.../vendor/behat/mink/driver-testsuite/tests/Js/ChangeEventTest.php:150
.../vendor/behat/mink/driver-testsuite/tests/Js/ChangeEventTest.php:113

10) Behat\Mink\Tests\Driver\Js\ChangeEventTest::testCheckChangeEvent with data set #1 (false)
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'1'
+'2'

.../vendor/behat/mink/driver-testsuite/tests/Js/ChangeEventTest.php:150
.../vendor/behat/mink/driver-testsuite/tests/Js/ChangeEventTest.php:113

11) Behat\Mink\Tests\Driver\Js\ChangeEventTest::testUncheckChangeEvent with data set #0 (true)
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'1'
+'2'

.../vendor/behat/mink/driver-testsuite/tests/Js/ChangeEventTest.php:150
.../vendor/behat/mink/driver-testsuite/tests/Js/ChangeEventTest.php:134

12) Behat\Mink\Tests\Driver\Js\ChangeEventTest::testUncheckChangeEvent with data set #1 (false)
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'1'
+'2'

.../vendor/behat/mink/driver-testsuite/tests/Js/ChangeEventTest.php:150
.../vendor/behat/mink/driver-testsuite/tests/Js/ChangeEventTest.php:134

[stof]

Waht we need to fix this is actually a new release of zombie. A fix has been commited months ago (2 weeks after we reported it)

[aik099]

Wow, I never knew that was a fix at all, can you post a link to fix here?

[stof]

Well, it was not referenced in the issue you reported (which is not closed either). I found it when looking at the history to try to identify what was new since the release

[stof]

The Zombie fix has been released