-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that "change" event is fired only once per "setValue" call #90
Comments
why talking about PhantomJS ? It has nothing to do with ZombieDriver. It is a Webdriver implementation |
Both Zombie and PhantomJS are headless and support JS. I though that for JS support they might be using same libraries. And if a bug, that causes It turned out that only Zombie does that and PhantomJS does all correctly. |
They don't use the same libraries at all. PhantomJS uses webkit (through the QTwebkit project, so an old version of webkit) while Zombie implements a browser in NodeJS (based on JSDom for the DOM implementations). |
Relevant test suite output:
|
Waht we need to fix this is actually a new release of zombie. A fix has been commited months ago (2 weeks after we reported it) |
Wow, I never knew that was a fix at all, can you post a link to fix here? |
Well, it was not referenced in the issue you reported (which is not closed either). I found it when looking at the history to try to identify what was new since the release |
The Zombie fix has been released |
Current results:
selectOption
forradio
: fires 2 times (no manual code, we just call.choose(
method, maybe bug in Zombie)check
: fires 2 times (no manual code, we just call.check(
method, maybe bug in Zombie)uncheck
: fires 2 times (no manual code, we just call.uncheck(
method, maybe bug in Zombie)To be on the safe side I've executed these tests on the PhantomJS and they fail the same way as for Selenium2. So it's something in Zombie that causes
change
to fired twice. Reported in assaf/zombie#675Tests added in Behat/Mink#495
The text was updated successfully, but these errors were encountered: