Merge pull request #131 from aik099/remove-session-proxy

Removed the "SessionProxy" class
minkphp · Mar 16, 2024 · 0be0ba6 · 0be0ba6
2 parents 1054f33 + b641d94
commit 0be0ba6
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 50 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 - Reduce memory consumption by rewriting `SessionStrategyFactory` and `SessionStrategyManager` classes.
 - (Not a BC break) Some public methods of the `BrowserTestCase` class are protected now. Affected methods: `setRemoteCoverageScriptUrl`, `setBrowser`, `getBrowser`, `setSessionStrategy`, `getSessionStrategy`, `getCollectCodeCoverageInformation`, `getRemoteCodeCoverageInformation`.
 - (Not a BC break) Some protected properties of the `BrowserTestCase` class are private now. Affected properties: `sessionStrategyManager`, `remoteCoverageHelper`, `sessionStrategy`.
+- Bumped minimal required `Behat/Mink` version to 1.8 (needed after `SessionProxy` class removal).
 
 ### Fixed
 - Don't set remote code coverage collection cookies, when the remote code coverage script URL isn't specified.

diff --git a/composer.json b/composer.json
@@ -14,7 +14,7 @@
 
 	"require": {
 		"php": ">=5.6",
-		"behat/mink": "~1.6@dev",
+		"behat/mink": "^1.8@dev",
 		"behat/mink-selenium2-driver": "~1.2",
 		"phpunit/phpunit": ">=4.8.35 <5|>=5.4.3",
 		"console-helpers/phpunit-compat": "^1.0.2"

diff --git a/composer.lock b/composer.lock
diff --git a/library/aik099/PHPUnit/Session/SessionFactory.php b/library/aik099/PHPUnit/Session/SessionFactory.php
@@ -31,7 +31,7 @@ class SessionFactory implements ISessionFactory
 	 */
 	public function createSession(BrowserConfiguration $browser)
 	{
-		return new SessionProxy($browser->createDriver());
+		return new Session($browser->createDriver());
 	}
 
 }
diff --git a/library/aik099/PHPUnit/Session/SessionProxy.php b/library/aik099/PHPUnit/Session/SessionProxy.php