Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made data provider methods static #123

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Made data provider methods static #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/PimpleCopy/Pimple/PimpleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ public function testExtendFailsForInvalidServiceDefinitions($service)
/**
* Provider for invalid service definitions.
*/
public function badServiceDefinitionProvider()
public static function badServiceDefinitionProvider()
{
return array(
array(123),
Expand All @@ -364,7 +364,7 @@ public function badServiceDefinitionProvider()
/**
* Provider for service definitions.
*/
public function serviceDefinitionProvider()
public static function serviceDefinitionProvider()
{
return array(
array(function ($value) {
Expand Down
14 changes: 9 additions & 5 deletions tests/aik099/PHPUnit/BrowserConfiguration/ApiBrowserConfigurationTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,12 @@ public function testSetDesiredCapabilitiesCorrect(array $desired_capabilities =
* Desired capability data provider.
*
* @return array
* @throws \RuntimeException When not overridden in a subclass.
*/
abstract public function desiredCapabilitiesDataProvider();
public static function desiredCapabilitiesDataProvider()
{
throw new \RuntimeException('Not overridden in a subclass');
}

/**
* Test description.
Expand Down Expand Up @@ -267,7 +271,7 @@ private function _isAutomaticTestName($test_name)
*
* @return array
*/
public function setupProcessDataProvider()
public static function setupProcessDataProvider()
{
$seed = uniqid();

Expand Down Expand Up @@ -333,7 +337,7 @@ public function testOnTestEnded($driver_type)
*
* @return array
*/
public function onTestEndedDataProvider()
public static function onTestEndedDataProvider()
{
return array(
array('selenium'),
Expand Down Expand Up @@ -362,7 +366,7 @@ public function testTestEndedWithoutSession($stopped_or_missing)
$this->browser->onTestEnded($test_case, $test_result);
}

public function sessionStateDataProvider()
public static function sessionStateDataProvider()
{
return array(
'session stopped/missing' => array(true),
Expand Down Expand Up @@ -435,7 +439,7 @@ public function testTunnelIdentifier($tunnel_id = null)
*
* @return array
*/
public function tunnelIdentifierDataProvider()
public static function tunnelIdentifierDataProvider()
{
return array(
array('AAA'),
Expand Down
2 changes: 1 addition & 1 deletion tests/aik099/PHPUnit/BrowserConfiguration/BrowserConfigurationFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public function testCreateBrowserConfiguration(array $browser_config, $type)
*
* @return array
*/
public function createBrowserConfigurationDataProvider()
public static function createBrowserConfigurationDataProvider()
{
return array(
array(array('type' => 'test'), 'test'),
Expand Down
4 changes: 2 additions & 2 deletions tests/aik099/PHPUnit/BrowserConfiguration/BrowserConfigurationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ public function testAliasResolution(array $aliases, array $browser_config, array
*
* @return array
*/
public function aliasResolutionDataProvider()
public static function aliasResolutionDataProvider()
{
return array(
'single alias' => array(
Expand Down Expand Up @@ -525,7 +525,7 @@ public function testGetSessionStrategyHashBrowserSharing($session_strategy)
*
* @return array
*/
public function sessionSharingDataProvider()
public static function sessionSharingDataProvider()
{
return array(
array(ISessionStrategyFactory::TYPE_ISOLATED),
Expand Down
6 changes: 2 additions & 4 deletions tests/aik099/PHPUnit/BrowserConfiguration/BrowserStackBrowserConfigurationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,9 @@ public function testSetHostCorrect()
}

/**
* Desired capability data provider.
*
* @return array
* @inheritDoc
*/
public function desiredCapabilitiesDataProvider()
public static function desiredCapabilitiesDataProvider()
{
return array(
array(
Expand Down
6 changes: 2 additions & 4 deletions tests/aik099/PHPUnit/BrowserConfiguration/SauceLabsBrowserConfigurationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,9 @@ public function testSetHostCorrect()
}

/**
* Desired capability data provider.
*
* @return array
* @inheritDoc
*/
public function desiredCapabilitiesDataProvider()
public static function desiredCapabilitiesDataProvider()
{
return array(
array(
Expand Down
2 changes: 1 addition & 1 deletion tests/aik099/PHPUnit/Fixture/ApiIntegrationFixture.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ public function testSuccess($data)
$this->assertTrue(true);
}

public function successDataProvider()
public static function successDataProvider()
{
return array(
'true' => array(true),
Expand Down
2 changes: 1 addition & 1 deletion tests/aik099/PHPUnit/Integration/DIContainerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public function testServiceDefinitions($service_id, $class_name)
*
* @return array
*/
public function serviceDefinitionsDataProvider()
public static function serviceDefinitionsDataProvider()
{
return array(
array('application', 'aik099\\PHPUnit\\Application'),
Expand Down
2 changes: 1 addition & 1 deletion tests/aik099/PHPUnit/Integration/DataProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class DataProviderTest extends BrowserStackAwareTestCase
),
);

public function sampleDataProvider()
public static function sampleDataProvider()
{
return array(
array('case1'),
Expand Down
2 changes: 1 addition & 1 deletion tests/aik099/PHPUnit/MinkDriver/DriverFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ protected function createBrowserConfiguration(IMinkDriverFactory $factory)
return $browser_configuration;
}

public function driverDataProvider()
public static function driverDataProvider()
{
return array(
'goutte' => array(
Expand Down
4 changes: 2 additions & 2 deletions tests/aik099/PHPUnit/RemoteCoverage/RemoteCoverageHelperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public function testCreateUrlError($coverage_script_url, $test_id)
*
* @return array
*/
public function createUrlErrorDataProvider()
public static function createUrlErrorDataProvider()
{
return array(
array('', 'test-id'),
Expand Down Expand Up @@ -114,7 +114,7 @@ public function testCreateUrl($coverage_script_url, $test_id, $expected_url)
*
* @return array
*/
public function createUrlDataProvider()
public static function createUrlDataProvider()
{
return array(
array('http://host', 'test-id', 'http://host?rct_mode=output&PHPUNIT_MINK_TEST_ID=test-id'),
Expand Down
2 changes: 1 addition & 1 deletion tests/aik099/PHPUnit/Session/SharedSessionStrategyTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public function testSessionSharing(\Exception $e = null)
*
* @return array
*/
public function ignoreExceptionDataProvider()
public static function ignoreExceptionDataProvider()
{
return array(
array(null),
Expand Down
2 changes: 1 addition & 1 deletion tests/aik099/PHPUnit/TestSuite/BrowserTestSuiteTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public function testNameFromBrowser(array $browser, $expected_name)
*
* @return array
*/
public function nameFromBrowserDataProvider()
public static function nameFromBrowserDataProvider()
{
return array(
array(array('alias' => 'match'), 'match'),
Expand Down