Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to determine session freshness state #128

Merged
merged 1 commit into from Mar 15, 2024

Conversation

aik099
Copy link
Member

@aik099 aik099 commented Mar 15, 2024

When dealing with shared session strategies it's hard to understand, whether the returned session was just created or was inherited from a previously executed test. This is not a problem now thanks to the $this->getSessionStrategy()->isFreshSession() code, that can be used anywhere during the test execution.

The practical use case for this functionality is to be able to perform login/logout once for all tests in the test case. Examples in the documentation were also updated to reflect this.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.58%. Comparing base (f1bb9db) to head (8999227).
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #128      +/-   ##
============================================
- Coverage     86.16%   82.58%   -3.58%     
  Complexity      330      330              
============================================
  Files            29       30       +1     
  Lines           860      867       +7     
============================================
- Hits            741      716      -25     
- Misses          119      151      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aik099 aik099 force-pushed the session-tracking-feat branch 2 times, most recently from 8d8e2d6 to 849e94d Compare March 15, 2024 11:34
@aik099 aik099 marked this pull request as draft March 15, 2024 16:41
@aik099 aik099 self-assigned this Mar 15, 2024
@aik099 aik099 marked this pull request as ready for review March 15, 2024 19:12
@aik099 aik099 merged commit fe5911c into minkphp:master Mar 15, 2024
12 of 13 checks passed
@aik099 aik099 deleted the session-tracking-feat branch March 15, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant