Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke "BrowserTestCase::onTestSuiteEnded" method only for executed tests #130

Merged
merged 1 commit into from Mar 16, 2024

Conversation

aik099
Copy link
Member

@aik099 aik099 commented Mar 16, 2024

The BrowserTestCase::onTestSuiteEnded event was also invoked for excluded tests. This happened because tests for iteration were retrieved from the TestSuite::tests method (which returns all tests and even those, that won't be executed).

Instead, interaction should be made through the TestSuite class object itself (as PHPUnit does). This has been fixed by this PR.

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.58%. Comparing base (fe5911c) to head (1c7a6e2).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #130      +/-   ##
============================================
- Coverage     86.27%   82.58%   -3.70%     
  Complexity      330      330              
============================================
  Files            30       30              
  Lines           867      867              
============================================
- Hits            748      716      -32     
- Misses          119      151      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aik099 aik099 changed the title Iterate PHPUnit test suite correctly Invoke "BrowserTestCase::onTestSuiteEnded" method only for executed tests Mar 16, 2024
@aik099 aik099 merged commit 1054f33 into minkphp:master Mar 16, 2024
11 of 12 checks passed
@aik099 aik099 deleted the test-suite-filters-fix branch March 16, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant