Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify driver installation process #133

Merged
merged 1 commit into from Mar 17, 2024

Conversation

aik099
Copy link
Member

@aik099 aik099 commented Mar 17, 2024

Changed error message formatting, that is shown, when driver package isn't installed.

Before PR:

Install MinkSelenium2Driver in order to use selenium2 driver.

After PR:

The "selenium2" driver package is not installed. Please follow installation instructions at https://packagist.org/packages/behat/mink-selenium2-driver.

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.98%. Comparing base (64070d5) to head (86ce20f).

Files Patch % Lines
...k099/PHPUnit/MinkDriver/Selenium2DriverFactory.php 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #133      +/-   ##
============================================
- Coverage     86.09%   82.98%   -3.12%     
- Complexity      326      328       +2     
============================================
  Files            28       29       +1     
  Lines           856      864       +8     
============================================
- Hits            737      717      -20     
- Misses          119      147      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aik099 aik099 merged commit a3be254 into minkphp:master Mar 17, 2024
11 of 12 checks passed
@aik099 aik099 deleted the simplify-driver-install branch March 17, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant