Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add minoca-pkg-test run to automation process #75

Closed
wants to merge 5 commits into from

Conversation

melezhik
Copy link
Contributor

@melezhik melezhik commented Dec 3, 2016

HI Evan! This is my very first try. I can't run it on my side obviously not having a Minoca automation processes here. Please let me know if anything else you need and if you are able to run this on your side.

Alexey

@evangreen
Copy link
Collaborator

Hi Alexey,
This is a great start. You were able to run the .sh scripts manually, right? If so, then things should work okay. We'll see what happens.

A couple of minor issues to fix up:

  • Can you put the headers at the top of the .sh files to describe a bit about these files? See tasks/build/make.sh for an example.
  • Rather than all the && operators, let's use set -e, which is a shell option that causes the entire script to exit with failure if any one of the commands within it fails. Again, see tasks/build/make.sh for an example.
  • For initial testing, let's also add set -x so that if something dies we can see what line in the script it made it to.

@melezhik
Copy link
Contributor Author

melezhik commented Dec 6, 2016

Hi Evan! Sure will take a looks at the corrections you say.

Meanwhile you may try this version, so we don't wait each other :)))

@melezhik
Copy link
Contributor Author

melezhik commented Dec 6, 2016

Hi Evan! I have just made a desired corrections. Thought not sure about copyright headers, so left them empty. Feel free to discuss.


opkg -f /etc/opkg/opkg.conf update
opkg -f /etc/opkg/opkg.conf install bash curl
curl -k -L https://cpanmin.us -o /usr/bin/cpan
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be: /usr/bin/cpanm instead of /usr/bin/cpan

@melezhik
Copy link
Contributor Author

melezhik commented Dec 6, 2016

Hi @test9753 !

+curl -k -L https://cpanmin.us -o /usr/bin/cpan

Sure it was I typo! Thanks for pointing this ...

@evangreen
Copy link
Collaborator

This looks better, thank you for making those changes.

Would you be able to electronically sign our Contributor Agreement? It assigns us the copyright over the patches you submit to the OS repository. Once that's done I'll rebase this in and we'll see how the builds go.

@melezhik
Copy link
Contributor Author

melezhik commented Dec 7, 2016

Hi Evan! As I started getting involved in Minoca development here is my question on Contributor Agreement.

I am not against to pass the rights on the code committed to Minoca github/gitlab repositories. But if we talk about sparrow/sparrowhub.org stuff I would like to act as owner of such materials, which remain untouched by the agreement.

Like ( for example ) if I do minoca-pkg-test sparrow plugin for you (Minoca project). If I signed the agreement I will still be the owner of the minoca-pkg-test sparrow plugin, right?

Let me know if I understand everything correct.

Regards

Alexey

@evangreen
Copy link
Collaborator

Hi Alexey. Very good question. The agreement covers work "submitted" to us, which is defined by the agreement. I'm not a lawyer, but I do not believe that code off in your own repositories that simply relates to Minoca is covered. Our goal here is not to absorb as much IP as possible, but just to make sure that we own everything in the os repository so that we can relicense it if needed.

The agreement mentions that you can explictly mark items you share with us as "Not a Contribution" if it's something you're sharing but don't intend to submit to the project. We understand that your Sparrow repositories are not a contribution, so consider those already marked as "not a contribution".

@melezhik
Copy link
Contributor Author

melezhik commented Dec 8, 2016

Ok, sounds like I am going to sign the CA, should we take an advise for Minoca lawers just in case or I can go ahead and sign?

@evangreen
Copy link
Collaborator

Ultimately you've got to decide for yourself, myself or my lawyers shouldn't tell you what to do.

@melezhik
Copy link
Contributor Author

melezhik commented Dec 8, 2016

Yeah, Evan, I am going to sign CA. Sorry for delay.

@melezhik
Copy link
Contributor Author

Hi Evan! I am getting

Server Error (500)

when posting agreement to http://www.minocacorp.com/ca/individual/

A FF debug info


Request:

Host: www.minocacorp.com
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: en-US,en;q=0.5
Accept-Encoding: gzip, deflate
Referer: http://www.minocacorp.com/ca/individual/
Cookie: __utma=59691313.331116493.1478023631.1481092594.1481567335.21; __utmz=59691313.1481092594.20.7.utmcsr=github.com|utmccn=(referral)|utmcmd=referral|utmcct=/minoca/os/pull/75; csrftoken=WrA7i7O3MDNwE9HWz5fm0ZFKTxW59dVN; __utmb=59691313.10.10.1481567335; __utmc=59691313; __utmt=1
Connection: keep-alive
Upgrade-Insecure-Requests: 1

Response:

Connection: close
Content-Type: text/html
Date: Mon, 12 Dec 2016 18:43:49 GMT
Server: Apache/2.4.7 (Ubuntu)
Transfer-Encoding: chunked
X-Frame-Options: SAMEORIGIN

@evangreen
Copy link
Collaborator

Try again now. I was having some weird issues with our mail server. (If you send a mail and don't hear from us in a couple days, send us a ping just in case).

@melezhik
Copy link
Contributor Author

melezhik commented Dec 13, 2016

HI Evan! I have successfully posted a request for CA, so awaiting email from Minoca
Hi Evan! Have you received my signed CA?

@evangreen
Copy link
Collaborator

Hi Alexey. I've pulled in, squashed, and rebased this pull request. I'll let you know how the builds go tonight!

@evangreen evangreen closed this Dec 14, 2016
@melezhik
Copy link
Contributor Author

Thanks. Evan ! Good news! 👍 I am anxious to see first run results !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants