code review fixes

minond · Feb 1, 2014 · 7835286 · 7835286
1 parent 32d48f2
commit 7835286
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/Efficio/Http/Rule.php b/src/Efficio/Http/Rule.php
@@ -129,8 +129,8 @@ public function matches($req)
     {
         $match = false;
         $matches = [];
-        $uri = $req;
         $runcheck = true;
+        $uri = is_string($req) ? $req : '';
 
         if ($req instanceof Request) {
             $uri = $req->getUri();

diff --git a/src/Efficio/Http/RuleBook.php b/src/Efficio/Http/RuleBook.php
@@ -76,6 +76,7 @@ public function all()
     public function matching($req, $merge = false)
     {
         $matching = null;
+        $matches = [];
 
         foreach ($this->rules as & $rule) {
             list($ok, $matches) = $rule->matches($req);