Roy/mempool #43
Merged
Roy/mempool #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royster57
requested review from
erubboli,
iljakuklic,
muursh,
TheQuantumPhysicist and
zorvan
as code owners
|
Looks fine. The transaction iterator thing is important. However, it's gonna be relatively complex to implement given that we want some separation in different subsystems. Please give it a thought on how that can be done without persistent locking. Before merging this, anyway, we'll make things more concrete. We need the serialization thing to be ready. I'll keep you updated. |
royster57
force-pushed
the
roy/mempool
branch
2 times, most recently
from
d7f04c4
to
d7a5bcb
Compare
sinitcin
approved these changes
Dec 15, 2021
royster57
force-pushed
the
roy/mempool
branch
from
d7a5bcb
to
1799291
Compare
royster57
force-pushed
the
roy/mempool
branch
2 times, most recently
from
1a67be2
to
c98403e
Compare
royster57
force-pushed
the
roy/mempool
branch
3 times, most recently
from
909f3a6
to
e9fb3b8
Compare
iljakuklic
reviewed
Jan 13, 2022
iljakuklic
reviewed
Jan 13, 2022
royster57
force-pushed
the
roy/mempool
branch
3 times, most recently
from
27cc9b1
to
eaf9bb2
Compare
royster57
force-pushed
the
roy/mempool
branch
5 times, most recently
from
eca2854
to
8c25058
Compare
royster57
force-pushed
the
roy/mempool
branch
from
8c25058
to
934bf58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beginning of a mempool implementation