has setting about crop background

[lssler]

mintty auto crop image to fit background
in wintext.c static void load_background_image_brush(HDC dc, wstring fn)
change:
HDC dc0 = CreateCompatibleDC(dc);
HBITMAP oldhbm0 = SelectObject(dc0, hbm);

  // prepare destination memory DC, 
  // create and select the destination bitmap into it

  ///////////////////////////////////////////
  //crop image
  int imgw = w;
  int imgh = h;
  if(bw*h > w*bh)
  {
    imgw = w;
    imgh = bh*imgw/bw;
  }
  else if (bw*h < w*bh)
  {
    imgh = h;
    imgw = bw*imgh/bh;

  }
  w = imgw;
  h = imgh;

[mintty]

I am missing an explanation what this piece of code is meant to suggest or achieve...

[lssler]

I am missing an explanation what this piece of code is meant to suggest or achieve...

it crop the picture to avoid deformation when window size changes, instead of scale image to fit window

[mintty]

I could try, but... could you clarify which of the background image modes is supposed to be affected?
How do you invoke mintty to get something that your patch changes?
Also, as I thought to have implemented all variations in the best way, what do you think is wrong about current behaviour?

[lssler]

background " _" is changed, it just change "scaled" to "crop".now ,i set background with " _", then window ratio is different from img ratio ,so, the img is scaled to window ratio. The code scale img with img's original ratio.It looks better when change window size

[mintty]

How do you invoke mintty to get something that your patch changes?

Please quote your command. Note there is a variation of behaviour already available, maybe prefix % to the image filename is what you want?
Otherwise, if you really mean to crop the image when resizing the terminal, it would not fill the complete background but would leave some empty area, which I do not consider desirable. On the other hand, there is also a tiling prefix *.

[lssler]

it will not has empty area,it will sacle until fill all area.

[lssler]

[mintty]

I don't like guesswork investigation so much. You have still not answered my question how you invoke mintty to demonstrate the difference (i.e. which mode of Background=... you use). Also there are two similar locations in the source file where your patch would fit.

[mintty]

OK, if I guess right (:/) instead of simple tiling, you want to scale first, keeping aspect ratio, then tile.
This is not suitable for images (see below) but may be OK for patterns intended for tiling.
It would not be a change, however (see example) but rather a new mode.

[mintty]

Prefix syntax could be _* (as these two functions are combined), +, , or :.

[lssler]

The code used in function "static void load_background_image_brush(HDC dc, wstring fn)"，in 1813 line

It is right scale first, keeping aspect ratio, then tile
The original tile is use pic size

[lssler]

If image is bigger then mintty size or more small ,the code can automatically scale img to suitable size.

[mintty]

It is right scale first

or bottom scale first, depending on the dimensions.
This proposal needs some time to settle; it needs another flag and integration into the option.

[mintty]

I introduced this now with background image prefix + in either option Background or OSC 11.

[mintty]

Released 3.6.2.