Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beyond the value range of arg_opts and file_opts.opti in config.c #1247

Closed
qdzhaov opened this issue Dec 13, 2023 · 4 comments
Closed

Beyond the value range of arg_opts and file_opts.opti in config.c #1247

qdzhaov opened this issue Dec 13, 2023 · 4 comments

Comments

@qdzhaov
Copy link

qdzhaov commented Dec 13, 2023

I File config.c,the type of variable arg_opts and file_opts.opti is uchar,value range is 0-255,but arraysize of options is 269,bigger than 255,so some options in configfile will be error on save.

static struct {
char * comment;
uchar opti;
} file_opts[lengthof(options) + MAX_COMMENTS];
static uchar arg_opts[lengthof(options)];

@Biswa96
Copy link
Contributor

Biswa96 commented Dec 13, 2023

It was probably fixed in this commit c374559

@qdzhaov
Copy link
Author

qdzhaov commented Dec 13, 2023

but arg_opts not fixed

static uchar arg_opts[lengthof(options)]

@ak2
Copy link
Contributor

ak2 commented Dec 16, 2023

Funny such a long-standing issue should come up twice in a couple of days. Thanks for spotting that arg_opts was affected too.

@mintty
Copy link
Owner

mintty commented Feb 24, 2024

Released 3.7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants