-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IME]CursorColour does not work with specific BackgroundColour #548
Comments
Did it work with any earlier version of mintty? |
I tried 2.1.5 and it does not work. I glanced over mintty code, and probably I found the reason. In win_text() function in wintext.c:
this code corrects the cursor color to the foreground color, if the cursor color is "too close" to the background color. I tried commenting out this code, and my .minttyrc worked well. This behavior may be an intended one, but I think this is too strict at least. I do not think colors (7, 54, 66) and (0, 138, 0) are "too close". About the color-contrast problem, I think it is the most simple to leave it to the users. Edit: this problem applies also to CursorColour. so you do not need to install IME. I put another .minttyrc to reproduce the problem. |
I have significantly reduced the minimum distance that triggers this behaviour. That restriction could arguably be removed at all, but the code has been in place for so long already... |
Tweaked previous patch. Minimum trigger raised again (although lower than before) but "brightening" the cursor colour rather than just changing it (algorithm was already in use for brightened ANSI colours). |
Released in 2.4.0. |
When I enable IME, the cursor color does not change with the configuration below:
but it works with this config:
I attached .minttyrc to reproduce the problem.
I am using mintty 2.3.6 x86_64-pc-cygwin on Windows 7 x64 and MS Office IME 2010.
minttyrc.txt
The text was updated successfully, but these errors were encountered: