Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.9.1 regression - multiline copy-paste loses spaces at end of line #800

Closed
tkelman opened this issue Sep 20, 2018 · 8 comments
Closed

2.9.1 regression - multiline copy-paste loses spaces at end of line #800

tkelman opened this issue Sep 20, 2018 · 8 comments

Comments

@tkelman
Copy link

tkelman commented Sep 20, 2018

Example:
image

Even copy-pasting that first input line into github is coming across as echo '1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 3132 33' but there's a space between the 31 and the 32 there in the source input. If I instead do echo ' 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33' (my window width is set to 92 at the moment) then the input is preserved, nothing gets dropped when I copy-paste.

This is changing the meaning and behavior in some cases when I try to copy-paste long commands from cating either shell scripts or my .bash_history.

@mintty
Copy link
Owner

mintty commented Sep 21, 2018

Fixed in repository.

@tkelman
Copy link
Author

tkelman commented Sep 21, 2018

Thanks. Will test 2.9.2 and report back once it's released and up on cygwin mirrors.

@mintty
Copy link
Owner

mintty commented Sep 21, 2018

Nagging me to release it soon? Agreed, I won't wait months like recent major releases to fix this regression.
However, even this one still needs to be tested thoroughly, with respect to space/non-space at the wrap position, and also double-width character impact. You are welcome to do some testing already until I find the time...

@tkelman
Copy link
Author

tkelman commented Sep 21, 2018

Same could be said for the commit that introduced the problem. I'm not in much of a position to build and test off master at the moment, but I will have to remember to hold back to 2.9.0 any time I update other packages.

@mintty
Copy link
Owner

mintty commented Sep 21, 2018

Revised fix in repository.

@d0ggie
Copy link

d0ggie commented Oct 3, 2018

Any updates? The broken 2.9.1 got unfortunately picked up by MSYS a couple of days ago, so now the issue is spreading even further :(

@mintty
Copy link
Owner

mintty commented Oct 3, 2018

Released 2.9.2.

@mintty mintty closed this as completed Oct 3, 2018
@tkelman
Copy link
Author

tkelman commented Oct 9, 2018

2.9.3 has been working well for me so far, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants