Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.3 renders U+2500 (horizontal line) incorrectly #918

Closed
avih opened this issue Sep 27, 2019 · 4 comments
Closed

3.0.3 renders U+2500 (horizontal line) incorrectly #918

avih opened this issue Sep 27, 2019 · 4 comments

Comments

@avih
Copy link
Contributor

avih commented Sep 27, 2019

Run the following test script:

#!/bin/bash

stty size | {
    read rows cols
    for x in `seq $cols`; do
        printf "\u2500"
    done
    echo
}

Expected result: horizontal line spanning the full width of the terminal.

Actual result: looks like spaced dashes, and it's shorter than expected.

This works in mintty 3.0.2 but not in 3.0.3, and affects e.g. tmux which uses such lines between panes.

I use the font Consolas.

@avih
Copy link
Contributor Author

avih commented Sep 27, 2019

BTW, I noticed that you added some auto-narrowing functionality. FWIW, glyphs which should span the cell edge-to-edge (like U+2500) are typically wider/higher than the cell, such that they align well and without gaps regardless of different cell spacing.

Maybe the heuristics detects that the glyph is "too wide" and narrows it instead of clipping it? Regardless though, even if it does narrow it, it seems that the renders are not aligned to the cell boundaries, because N such consecutive glyphs end up shorter than the width of N cells.

mintty added a commit that referenced this issue Sep 27, 2019
first approach to mitigate line squeezing (#918)
@mintty
Copy link
Owner

mintty commented Oct 1, 2019

Released 3.0.4.

@mintty mintty closed this as completed Oct 1, 2019
@Biswa96
Copy link
Contributor

Biswa96 commented Oct 1, 2019

This also fixed the horizontal separation line in tmux.

@avih
Copy link
Contributor Author

avih commented Oct 1, 2019

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants