Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabbar: Fix startup position #1044

Merged
merged 1 commit into from Oct 15, 2020
Merged

Conversation

k-takata
Copy link
Contributor

When tabbar is enabled, users may expect that all mintty windows are
placed at the same position.
If Alt+F2 is used, the new window is placed at the same position as the
current window. However, if mintty is executed in another way, the
position is not the same as the current window.

This fixes the position of a new window even if Alt+F2 is not used.

When tabbar is enabled, users may expect that all mintty windows are
placed at the same position.
If Alt+F2 is used, the new window is placed at the same position as the
current window. However, if mintty is executed in another way, the
position is not the same as the current window.

This fixes the position of a new window even if Alt+F2 is not used.
@mintty mintty merged commit f589308 into mintty:master Oct 15, 2020
@mintty
Copy link
Owner

mintty commented Oct 15, 2020

Thanks for finding this tricky solution for this problem.
One issue remains: If I run 2 tabbar-enabled windows (say 1 and 2) from 1 non-tabbar window (window 0), window 2 will not align with window 1 but rather with window 0.
I have no idea how this could be handled too, and people who always run with tabbar will not care much, so let's ignore it.

mintty added a commit that referenced this pull request Oct 15, 2020
@k-takata k-takata deleted the tabbar-startpos branch October 15, 2020 09:57
k-takata added a commit to k-takata/mintty that referenced this pull request Oct 16, 2020
This is an additional fix to mintty#1044.
Distinguish a maximised window from a fullscreen window.
k-takata added a commit to k-takata/mintty that referenced this pull request Oct 16, 2020
This is an additional fix to mintty#1044.
Distinguish a maximised window from a fullscreen window.
@mintty
Copy link
Owner

mintty commented Oct 24, 2020

Released 3.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants