Fix option index overflow in remember_file_options #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are more than 256 config options (!), which means that using a uchar is no longer sufficient for storing the index of options found in the config file or changed in the UI. The overflow meant that for example a BoldBlue setting in the config file (which currently has option index 262) turned into a TekForegroundColour setting (with index 6) when changing some unrelated setting in the config dialog and saving.
|
Hmm, I wonder what obscure behaviour this may have caused in the past. |
|
Released 3.7.1. |
This was referenced Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are more than 256 config options (!), which means that using a uchar is no longer sufficient for storing the index of options found in the config file or changed in the UI.
The overflow meant that for example a BoldBlue setting in the config file (which currently has option index 262) turned into a TekForegroundColour setting (with index 6) when changing some unrelated setting in the config dialog and saving.