Twitter commands #6

citypaul · 2016-01-19T23:58:19Z

So I made a few changes here to make the twitter stuff a bit nicer.

I should say I'm doing this blind without a robot and without... tests! Shock horror! So I can't confirm it works unless you try it out for me.

I refactored some of the commands so they no longer create the bb8 instance. I figured they are just commands and should do nothing more than take an instance of bb8 that is already created and run commands against him. This meant I could then pass commands from twitter quite easily. I had a go at refactoring the index script accordingly.

There's a config folder with a place for you to store your twitter api details. I couldn't see a way of using twitter's api without these details. If there is a way please alter the code or let me know and I'll do it...

The twitter command is pretty basic at the moment - it polls twitter every 10 seconds searching for the hashtag #bb8bbc, and then looks for the first hashtag it finds in that tweet. It then simply issues that as the command.

It doesn't check to see whether the command exists or deal with more than one command etc right now, but it's a start.

So to make BB8 roll you'd do:

#roll #bb8bbc

I think extracting the commands as functions that simply receive a bb8 instance is a nice improvement - removes duplication and means you could start combining the commands together in theory.

Dunno if it works though! Try it out :)

citypaul · 2016-01-20T00:00:25Z

config/twitter_keys.EXAMPLE.js

@@ -0,0 +1,6 @@
+module.exports = {


Obviously to get this to work you need to add your twitter api details here, and remove the .EXAMPLE from this file. If there's a better way of doing this without creating this stuff just let me know and I'll change it :-)

citypaul · 2016-01-20T00:07:58Z

commands/disco.js

+    bb8.randomColor();
+    setInterval(function () {
+        bb8.randomColor();
+    }, 1000);


This feels a bit more betterer ;)

citypaul · 2016-01-20T00:15:05Z

index.js

+            require(command)(bb8)
+        });
+    }
+};


This block from line 3-11 could probably be extracted into its own lib...

mintuz · 2016-01-20T08:01:25Z

config/twitter_keys.EXAMPLE.js

@@ -0,0 +1,6 @@
+module.exports = {
+    consumer_key: '',
+    consumer_secret: '',


do you need the consumer key and secret? back in the day you could get away with just the access_token_key and access_token_secret similar to what I wrote in the Github wrapper in libs?

Might be good to do it like that to be consistent. I made it so it reads either a config passed in through the CLI or a ENV variable (process.env.NAME_OF_VAR)

mintuz · 2016-01-20T08:05:46Z

@citypaul Few minor things but looks good otherwise 👍 Add yourself to the README as well ;)

citypaul · 2016-01-20T09:15:36Z

commands/tweet.js

+
+    setInterval(function () {
+        executeTwitterCommand();
+    }, 10000);


I'll make this delay param configurable too...

… hashtag to search for + change interval delay

…ables

citypaul · 2016-01-23T12:34:22Z

Ok, updated a few things this morning:

Can now set the hashtag to search for from the command line
Can now set the interval time for searching twitter from command line
Twitter api config can come through from environment variables or cli options

I tried querying twitter without the consumer key and consumer secret, but it didn't work, so for now I've left this in. If there is a way of removing these, please go ahead and remove them 👍

mintuz · 2016-01-23T20:01:58Z

@citypaul I've done some tweaks to your code. It's working nicely now. Swapped some code for some lodash.

citypaul · 2016-01-23T20:25:09Z

@mintuz Nice! I hadn't thought about the fact the robot would keep getting the same command issued... One of the perils of not having an actual robot (and not writing tests I guess 😉).

Looks good though. I need to read up on the lodash stuff. That _.partial method looks interesting...

mintuz · 2016-01-23T20:28:20Z

_.partial can partially apply some of the arguments to a function and return a new function with the parematers that have not been passed in. I'm only using it because when it comes to testing it (eventually) it's easier to do dependency injection. I also think it makes the code look slightly nicer. You don't have to use it in this circumstance I just thought it would be nice.

mintuz · 2016-01-23T20:28:45Z

Anyways going to merge. Good work 👍 now go buy one 😄

Twitter commands

Paul Hammond added 7 commits January 19, 2016 23:01

smegging arond

31d7b57

turning the disco command into just a command

b95b582

package.json

60ee2d4

think this will work?

e221400

twitter keys

d455c42

polling twitter

fe840ab

removing intellij crap

464da9e

citypaul reviewed Jan 20, 2016
View reviewed changes

Paul Hammond added 2 commits January 20, 2016 00:01

they see me rollin'

5b1454d

refactoring weather command

96000cc

citypaul reviewed Jan 20, 2016
View reviewed changes

more weathering

38ba364

citypaul reviewed Jan 20, 2016
View reviewed changes

index.js

require(command)(bb8)

});

}

};

Copy link

Contributor Author

citypaul Jan 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block from line 3-11 could probably be extracted into its own lib...

Paul Hammond added 4 commits January 20, 2016 00:20

refactor disconnect command

88808a2

refactor tweet command slightly

cb7c77d

refactor tweet command slightly

1d44ae9

inline

6effc3c

mintuz reviewed Jan 20, 2016
View reviewed changes

citypaul reviewed Jan 20, 2016
View reviewed changes

Paul Hammond added 4 commits January 23, 2016 11:51

passing through command line arguments + making it possible to change…

88078f7

… hashtag to search for + change interval delay

updating readme

5401596

changing twitter setup to work from command line and environment vari…

e6fb603

…ables

updating .gitignore

ddc3670

updating readme

5feea83

Tweaks to twitter code to make it more flexible/fixed a bug

85ae066

mintuz added 4 commits January 23, 2016 20:04

Tidy up weather when im at it

792f79a

README updated

3d59400

tweak to prevent the same command being executed

ab18d7e

coding style tweaks

07a5364

mintuz added a commit that referenced this pull request Jan 23, 2016

Merge pull request #6 from citypaul/twitter

82ed900

Twitter commands

mintuz merged commit 82ed900 into mintuz:master Jan 23, 2016

mintuz deleted the twitter branch January 23, 2016 20:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Twitter commands #6

Twitter commands #6

citypaul commented Jan 19, 2016

citypaul Jan 20, 2016

citypaul Jan 20, 2016

mintuz Jan 20, 2016

citypaul Jan 20, 2016

mintuz Jan 20, 2016

mintuz commented Jan 20, 2016

citypaul Jan 20, 2016

mintuz Jan 20, 2016

citypaul commented Jan 23, 2016

mintuz commented Jan 23, 2016

citypaul commented Jan 23, 2016

mintuz commented Jan 23, 2016

mintuz commented Jan 23, 2016

Twitter commands #6

Twitter commands #6

Conversation

citypaul commented Jan 19, 2016

citypaul Jan 20, 2016

Choose a reason for hiding this comment

citypaul Jan 20, 2016

Choose a reason for hiding this comment

mintuz Jan 20, 2016

Choose a reason for hiding this comment

citypaul Jan 20, 2016

Choose a reason for hiding this comment

mintuz Jan 20, 2016

Choose a reason for hiding this comment

mintuz commented Jan 20, 2016

citypaul Jan 20, 2016

Choose a reason for hiding this comment

mintuz Jan 20, 2016

Choose a reason for hiding this comment

citypaul commented Jan 23, 2016

mintuz commented Jan 23, 2016

citypaul commented Jan 23, 2016

mintuz commented Jan 23, 2016

mintuz commented Jan 23, 2016