This repository has been archived by the owner on Oct 10, 2020. It is now read-only.
App crash on orientation change #208 #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devtronic
suggested changes
Apr 14, 2020
| @@ -17,7 +17,6 @@ class BarcodeScannerActivity : Activity(), ZXingScannerView.ResultHandler { | |||
|
|
|||
| private lateinit var config: Protos.Configuration | |||
| lateinit var scannerView: ZXingScannerView | |||
There was a problem hiding this comment.
Maybe it's better to change the scannerView to a nullable private var (just to prevent further problems like this one):
private var scannerView: ZXingScannerView? = null| @@ -49,7 +48,7 @@ class BarcodeScannerActivity : Activity(), ZXingScannerView.ResultHandler { | |||
| } | |||
|
|
|||
| private fun setupScannerView() { | |||
| if (scannerViewInitialized) { | |||
| if (this::scannerView.isInitialized) { | |||
There was a problem hiding this comment.
if (scannerView != null) {
return
}| } | ||
|
|
||
| // region AppBar menu | ||
| override fun onCreateOptionsMenu(menu: Menu): Boolean { | ||
| var buttonText = config.stringsMap["flash_on"] | ||
| if (scannerView.flash) { | ||
| if (this::scannerView.isInitialized && scannerView.flash) { |
There was a problem hiding this comment.
if (scannerView?.flash == true) {
buttonText = config.stringsMap["flash_off"]
}
|
Thanks for contributing. I added a few comments to your changes 🙂 |
|
Updated the code based on your feedback :) |
|
Thanks 🙂 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.