Merge pull request #4 from open-source-contributions/enhance_tests

Enhance temp file initialization for tests
mintware-de · Sep 10, 2019 · 27f1f91 · 27f1f91
2 parents b7e85d7 + 543cd3f
commit 27f1f91
Showing 1 changed file with 14 additions and 7 deletions.
diff --git a/tests/FileStreamTest.php b/tests/FileStreamTest.php
@@ -17,6 +17,13 @@
 
 class FileStreamTest extends TestCase
 {
+    protected $tempFile;
+
+    protected function setUp()
+    {
+        $this->tempFile = tempnam(sys_get_temp_dir(), 'stream_test');
+    }
+
     public function testConstructor()
     {
         $stream = new FileStream(__FILE__, true, false);
@@ -26,17 +33,12 @@ public function testConstructor()
         $this->assertFalse($stream->isWritable());
         $stream->close();
 
-        $tempFile = tempnam(sys_get_temp_dir(), 'stream_test');
-        $stream = new FileStream($tempFile, true, true);
+        $stream = new FileStream($this->tempFile, true, true);
         $this->assertInstanceOf(StreamInterface::class, $stream);
         $this->assertEquals(0, $stream->getSize());
         $this->assertTrue($stream->isReadable());
         $this->assertTrue($stream->isWritable());
         $stream->close();
-
-        if (is_file($tempFile)) {
-            @unlink($tempFile);
-        }
     }
 
     public function testConstructorFailsNoFile()
@@ -45,4 +47,9 @@ public function testConstructorFailsNoFile()
         $this->expectExceptionMessage('fopen(21312asd): failed to open stream: No such file or directory');
         new FileStream('21312asd', true, false);
     }
-}
+
+    protected function tearDown()
+    {
+        unlink($this->tempFile);
+    }
+}