added .indentifySources()

minum · Apr 23, 2013 · a2c7b06 · a2c7b06
1 parent 4d260d4
commit a2c7b06
Show file tree

Hide file tree

Showing 4 changed files with 124 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -60,6 +60,18 @@ Only aggregate values, source will not be aggregated and return values aggregati
 
     Metrics.aggregate = function(name, resolution, valueAggregator, sourceAggregator, query, callback){}
 
+##### identifySources
+
+identify sources available for a given metric
+
+        @param {String} name - name of the metric
+        @param {Object} query - mongodb query for filtering out metrics
+            only supports date only
+        @param {Function} callback - callback function
+            callback(err, resultsArray)
+
+    Metrics.indentifySources = function (name, query, callback) {}
+
 #### Example
 
 ~~~js

diff --git a/lib/metrics.js b/lib/metrics.js
@@ -117,7 +117,7 @@ function Metrics (mongoUrl, collection) {
             possible values: "sum", "avg", "min", "max"
         @param {Array} sourceFilter - list of sources need to be return in the result. if empty all the sources will be retured
         @param {Object} query - mongodb query for filtering out metrics
-            only supports date and source only
+            only supports date only
         @param {Function} callback - callback function
             callback(err, results)
     */
@@ -164,6 +164,53 @@ function Metrics (mongoUrl, collection) {
         });
     };
 
+    /*
+        identify sources available for a given metric
+
+        @param {String} name - name of the metric
+        @param {Object} query - mongodb query for filtering out metrics
+            only supports date only
+        @param {Function} callback - callback function
+            callback(err, resultsArray)
+    */
+    this.identifySources = function identifySources(name, query, callback) {
+
+        if(typeof(query) == 'function') {
+            callback = query;
+            query = {};
+        }
+
+        var filter = { name: name };
+        ['date'].forEach(function(field) {
+
+            if(query[field]) {
+                filter[field] = query[field];
+            }
+        });
+        var aggreation = [
+            {$match: filter},
+            {$group: {_id: "$source", val: {$sum: 1}}}
+        ];
+
+        mongoDatabase.ready(function() {
+
+            mongoDatabase.db.collection(collection).aggregate(aggreation, filterOnlySourceNames);
+        });
+
+        function filterOnlySourceNames(err, results) {
+
+            if(err) {
+                callback(err);
+            } else {
+                var sourceNames = [];
+                results.forEach(function(item) {
+                    sourceNames.push(item._id);
+                });
+                callback(null, sourceNames);
+            }
+        }
+    };
+
     this._generateValueGrouping = function _generateValueGrouping(resolution, aggregator) {
 
         var _id = {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "minum",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "description": "Core 'minum' module with backend tracking and aggregation",
   "keywords": [
     "metrics",

diff --git a/test/metrics.js b/test/metrics.js
@@ -199,6 +199,69 @@ suite('Metrics', function() {
             }
         }));
     });
+
+    suite('.identifySources()', function() {
+
+        test('without query', _clean(function(done) {
+
+            var metrics = [
+                {name: 'mp3', value: 10, source: 'b1', date: new Date('2012 01 01 10:45 GMT')},
+                {name: 'mp3', value: 8, source: 'b2', date: new Date('2012 01 01 10:45 GMT')},
+                {name: 'mp3', value: 8, source: 'b1', date: new Date('2012 01 01 10:45 GMT')},
+                {name: 'mp3', value: 6, source: 'b2', date: new Date('2012 01 01 10:45 GMT')},
+                {name: 'other', value: 6, source: 'b2', date: new Date('2012 01 01 10:46 GMT')}
+            ];
+
+            var mm = metricsIo(MONGO_URL, COLLECTION);
+
+            addBulkMetrics(mm, metrics, function(err) {
+
+                assert.equal(err, undefined);
+                mm.identifySources('mp3', validateMetrics);
+            });
+
+            function validateMetrics(err, results) {
+
+                assert.equal(err, null);
+                results.sort(function(a, b) {
+                    return a > b;
+                });
+                assert.deepEqual(results, ['b1', 'b2']);
+                done();
+            }
+
+        }));
+
+        test('with query', _clean(function(done) {
+
+            var metrics = [
+                {name: 'mp3', value: 10, source: 'b1', date: new Date('2012 01 01 10:45 GMT')},
+                {name: 'mp3', value: 8, source: 'b2', date: new Date('2013 01 01 10:45 GMT')},
+                {name: 'mp3', value: 8, source: 'b1', date: new Date('2012 01 01 10:45 GMT')},
+                {name: 'mp3', value: 6, source: 'b2', date: new Date('2013 01 01 10:45 GMT')},
+                {name: 'other', value: 6, source: 'b2', date: new Date('2012 01 01 10:46 GMT')}
+            ];
+
+            var mm = metricsIo(MONGO_URL, COLLECTION);
+
+            addBulkMetrics(mm, metrics, function(err) {
+
+                assert.equal(err, undefined);
+                mm.identifySources('mp3', {date: {$lt: new Date('2012 12 31').getTime()}}, validateMetrics);
+            });
+
+            function validateMetrics(err, results) {
+
+                assert.equal(err, null);
+                results.sort(function(a, b) {
+                    return a > b;
+                });
+                assert.deepEqual(results, ['b1']);
+                done();
+            }
+
+        }));
+    });
 });
 
 function addBulkMetrics (metricsTracker, metrics, callback) {