Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ember-inflector from 3.x to 4.x #143

Merged
merged 1 commit into from Jun 29, 2021

Conversation

mydea
Copy link
Contributor

@mydea mydea commented Jun 10, 2021

To fix this deprecation warning in latest ember versions:

WARNING: [DEPRECATION] [DEPRECATION] Usage of the Ember Global is deprecated. You should import the Ember module or the specific API instead.

See https://deprecations.emberjs.com/v3.x/#toc_ember-global for details.

Usages of the Ember Global may be caused by an outdated ember-cli-babel dependency. The following steps may help:

* Upgrade the following addons to the latest version:
  * ember-can

### Important ###

In order to avoid repeatedly showing the same deprecation messages, no further deprecation messages will be shown for usages of the Ember Global until ember-cli-babel is upgraded to v7.26.6 or above.

To see all instances of this deprecation message, set the `EMBER_GLOBAL_DEPRECATIONS` environment variable to "all", e.g. `EMBER_GLOBAL_DEPRECATIONS=all ember test`.

### Details ###

Prior to v7.26.6, ember-cli-babel sometimes transpiled imports into the equivalent Ember Global API, potentially triggering this deprecation message indirectly, even when you did not observe these deprecated usages in your code.

The following outdated versions are found in your project:

* ember-cli-babel@6.18.0, currently used by:
  * ember-inflector@3.0.1
    * Depends on ember-cli-babel@^6.6.0
    * Added by ember-can@3.1.0

@ef4
Copy link

ef4 commented Jun 28, 2021

This is also important for embroider. This old copy of ember-inflector blows up if other copies are present, which is very common. The symptom looks like Cannot redefine property: pluralize.

@Exelord
Copy link
Collaborator

Exelord commented Jun 29, 2021

Thanks a lot!

@Exelord Exelord merged commit 88060d1 into minutebase:master Jun 29, 2021
@mydea mydea deleted the fn/update-ember-inflector branch September 23, 2021 06:26
@mydea
Copy link
Contributor Author

mydea commented Sep 23, 2021

Could we maybe get a release with this change? That would be awesome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants