Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade Node version needed to 14.* #146

Closed
wants to merge 1 commit into from
Closed

chore: upgrade Node version needed to 14.* #146

wants to merge 1 commit into from

Conversation

Gorzas
Copy link
Contributor

@Gorzas Gorzas commented Jul 6, 2021

Close #145

Exelord
Exelord requested changes Jul 7, 2021
View reviewed changes
Copy link
Collaborator

@Exelord Exelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not depend on webpack in anyway, so we cannot include it in dependencies.

@Gorzas Gorzas force-pushed the hotfix-145/fix-auto-import-dependency branch from dca8237 to 5e5adc1 Compare July 15, 2021 14:33
@Gorzas Gorzas changed the title fix: add webpack as dependency chore: upgrade Node version needed to 14.* Jul 15, 2021
@Gorzas Gorzas mentioned this pull request Jul 15, 2021
Open
Exelord
Exelord requested changes Jul 19, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@Gorzas Gorzas force-pushed the hotfix-145/fix-auto-import-dependency branch from 5e5adc1 to 34dc56c Compare July 20, 2021 12:41
@Exelord Exelord added the breaking Breaking Change label Jul 21, 2021
@Exelord
Copy link
Collaborator

Exelord commented Jul 21, 2021

There is one more thing that bothers me 🤔 why all tests are passing on node 12 on CI?

@Gorzas
Copy link
Contributor Author

Gorzas commented Jul 21, 2021

There is one more thing that bothers me 🤔 why all tests are passing on node 12 on CI?

I think the problem I had was with npm v6 not with node v12. In the tests it's installing the latest NPM version.

@Gorzas
Copy link
Contributor Author

Gorzas commented Jul 27, 2021 •
edited
Loading

It seems I have to do another change. Tests are failing for ember-beta and ember-canary.

@charlesfries charlesfries mentioned this pull request Apr 2, 2024
Merged
@mkszepp
Copy link
Contributor

mkszepp commented May 13, 2024 •
edited
Loading

@esbanarango we can close this, as we have updated to node v18. When we move to v2 addon the node version is not anymore necessary to specificy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exelord Exelord Exelord requested changes

Assignees
No one assigned
Labels
breaking Breaking Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when running tests: this version of ember-auto-import requires the app to have a dependency on webpack
4 participants
@Gorzas @Exelord @mkszepp @esbanarango