feat: install TypeScript

[charlesfries]

• Install TypeScript
• Install DefinitelyTyped packages from Ember addon blueprint
• Install @types/ember-data__model
• Configure eslint for TS
• Type AbilitiesService

[charlesfries]

@minutebase @rlivsey Any interest in this?

[bartocc]

I've started adding type definitions for ember-can in our codebase as well.

It would be great to have types for this lib indeed 🤗

ping @Exelord

[Exelord]

I know, need that as well :) Ember-can is awaiting a major upgrade soon.

[bartocc]

I know, need that as well :) Ember-can is awaiting a major upgrade soon.

is this upgrade already started, or is it about to?

And in parallel, do you want more PRs with type definitions like this one?

[Exelord]

It's happening :) some changes just landed. TS will be welcome for upcoming v5

[guidojw]

@Exelord Is it still happening? 😋
I am slowly but surely converting our Ember app to TS and this addon is one of the few that doesn't come with types yet.

[Exelord]

Unfortunately I don't have enough time to work on it anymore :/ so the progres on next upgrade is on hold.

[esbanarango]

@Exelord Is there anything we could help with to either merge this PR or move the V5 forward? 🙏

[Exelord]

Hey @esbanarango,

As mentioned, currently I do not have time to maintain this package. I am really sorry for that. I would recommend maintaining own fork with changes that are needed for your project taking into account how small this package is.

[acorncom]

@Exelord are you able to hand over maintenance to others who do have the time? Completely understood that you have other time constraints on your end, yet there's still interest in having a shared add-on that the community uses for this ...

[Exelord]

Hi @acorncom,

I have the rights to do it, but I am not the owner of this addon.

@rlivsey would you like to choose a new maintainer or pass ownership to someone?

[RobbieTheWagner]

@Exelord @rlivsey might I suggest transferring this to adopted-ember-addons?

[mkszepp]

@rlivsey would be nice to transfer this addon to adopted-ember-addons or to get a new maintainer, so that the addon can be migrate to TS and addon v2

[Exelord]

I cannot move the repo, but as the author is not responding, I will grant maintenance permission.

Who would like to take it over?

[esbanarango]

@Exelord I can help

[RobbieTheWagner]

I'm also willing to help. Getting this in would be great 😄

[Exelord]

Done. Please sync with each other on next steps :) @RobbieTheWagner @esbanarango

[RobbieTheWagner]

Thanks @Exelord! @esbanarango do you have the cycles to take a look at getting this ready to merge? I won't have availability for probably a few weeks.

[esbanarango]

@RobbieTheWagner Yeah, I'll take a look! @charlesfries Let me know once this is ready 🤝

[charlesfries]

@esbanarango should be good now

[charlesfries]

Needed to update this to fix a build error:

ERROR in ./node_modules/@sinonjs/fake-timers/src/fake-timers-src.js 104:479-504
Module not found: Error: Can't resolve 'util' in 'C:\Users\xxx\ember-can\node_modules\@sinonjs\fake-timers\src'

[charlesfries]

Needed to update this to fix a Glint TS error:

node_modules/@glint/environment-ember-loose/-private/dsl/integration-declarations.d.ts:107:16 - error TS2665: Invalid module name in augmentation. Module '@ember/test-helpers' resolves to an untyped module at 'C:/Users/xxx/ember-can/node_modules/@ember/test-helpers/index.js', which cannot be augmented.