-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: install TypeScript & update dependencies #165
Conversation
# Conflicts: # addon/services/can.ts # package-lock.json # package.json
# Conflicts: # package-lock.json # package.json
…t-ember-loose & @glint/template (will be added later)
@RobbieTheWagner @esbanarango this changes are ready for merge (test scenarios should pass, at least local it works 😊). When this changes are landed, we can go on with moving everything to a v2 addon |
@charlesfries @esbanarango i'm not 100% sure, but i thinks the "model" typing is atm not correctly... we do require ember-data models, which is very strict... i think correct should be something like this: export interface Model {
[key: string]: unknown;
} I will replace it while v2 addon migration. Let me know if I'm right about this |
@RobbieTheWagner we should also label this PR... its |
@mkszepp you say updating ember-cli-babel is a breaking change. If so, we should label this |
@RobbieTheWagner i was in opinion, that is braking, because we change dependency... but upgrade docs says its never braking see https://github.com/emberjs/ember-cli-babel/blob/master/UPGRADING.md#upgrade-path-for-addons . so its okay to label only as In additional we have converted to v2 addon, so its never braking |
extends #164
following changes were done
ember-cli
to5.8
pnpm
(its easier moving now, instead switching while v2 addon migration)Atm we are compatbile to v3.20+ (like before, but we should support in future only v3.28+)
Using native types instead of typed packages we will do in v2 migration. Also glint support will be added in v2 migration.
Please look commit per commit, to understand everything what was changed