Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: install TypeScript & update dependencies #165

Merged
merged 33 commits into from
May 13, 2024

Conversation

mkszepp
Copy link
Contributor

@mkszepp mkszepp commented May 10, 2024

extends #164

following changes were done

  • update ember-cli to 5.8
  • fix typescript errors
  • activate const lint rule (default is on)
  • update all packages
  • update ember-cli-babel (this was a braking change for now!) -> when we are move later to v2 addon this will not be braking
  • switch to package-manager pnpm (its easier moving now, instead switching while v2 addon migration)

Atm we are compatbile to v3.20+ (like before, but we should support in future only v3.28+)

Using native types instead of typed packages we will do in v2 migration. Also glint support will be added in v2 migration.

Please look commit per commit, to understand everything what was changed

@mkszepp
Copy link
Contributor Author

mkszepp commented May 10, 2024

@RobbieTheWagner @esbanarango this changes are ready for merge (test scenarios should pass, at least local it works 😊). When this changes are landed, we can go on with moving everything to a v2 addon

@esbanarango esbanarango merged commit d075697 into minutebase:master May 13, 2024
15 checks passed
@mkszepp mkszepp deleted the update-packages branch May 13, 2024 05:08
@mkszepp mkszepp mentioned this pull request May 13, 2024
@mkszepp
Copy link
Contributor Author

mkszepp commented May 13, 2024

@charlesfries @esbanarango i'm not 100% sure, but i thinks the "model" typing is atm not correctly... we do require ember-data models, which is very strict... i think correct should be something like this:

export interface Model {
  [key: string]: unknown;
}

I will replace it while v2 addon migration. Let me know if I'm right about this

@mkszepp
Copy link
Contributor Author

mkszepp commented May 22, 2024

@RobbieTheWagner we should also label this PR... its enhancement & internal (only TS was added & addon was updated to v5.8)

@RobbieTheWagner
Copy link
Collaborator

@mkszepp you say updating ember-cli-babel is a breaking change. If so, we should label this breaking.

@mkszepp
Copy link
Contributor Author

mkszepp commented May 23, 2024

@RobbieTheWagner i was in opinion, that is braking, because we change dependency... but upgrade docs says its never braking see https://github.com/emberjs/ember-cli-babel/blob/master/UPGRADING.md#upgrade-path-for-addons . so its okay to label only as enhancement.

In additional we have converted to v2 addon, so its never braking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants