Migrate blueprint to ES6 class #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's important to notice that they may be some caveats using ES6 classes. Anyway, we are using this type of blueprint on our current projects (working on production) and we haven't found anything buggy yet. |
|
Native classes are only supported from ember 3.6. We need to provide wider support :/ |
|
@Exelord Ok, maybe we can do something to choose the blueprint depending on the Ember version? I think there're other libraries that do it. Do you know a way to do it? |
|
I float this merge request as ember-can now requires Ember 3.8 and above. Can we have this merge request accepted o should I close it? |
|
Yep :) Thank you for bringing it up once more! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #92