Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silently fails with fingerprinted SVGs #43

Open
mirague opened this issue Jul 11, 2017 · 4 comments
Open

Silently fails with fingerprinted SVGs #43

mirague opened this issue Jul 11, 2017 · 4 comments

Comments

@mirague
Copy link

mirague commented Jul 11, 2017

My SVG was inlined correctly like this:

    {{#link-to "games.index"}}
      <figure class="logo-full">
        {{inline-svg "/images/app-logo.svg"}}
      </figure>
    {{/link-to}}

However, once I configured SVGs to be fingerprinted, it stopped working. Now it renders nothing.

Is this supposed to work with fingerprinting?

@mirague
Copy link
Author

mirague commented Mar 8, 2018

Any pointers on how to make it work with fingerprinted SVGs? Currently we need to manually exclude every SVG that I want to inline, which is not very maintainable and makes us lose the benefits of fingerprinting.

@rlivsey

@arthur5005
Copy link

@mirague Having the same problem. I imagine running the strings through a helper that strips the prepend might work. That's probably what's preventing the inline-helper component from finding the asset on compilation.

@rlivsey

@timmyomahony
Copy link

This is still an issue. I've removed the plug-in because of it

@Lukom
Copy link

Lukom commented May 26, 2022

replaced this package with ember-svg-jar because of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants