Fix IE11 issues by fixing transpilation issues #1535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VWSCoronaDashboard10
requested review from
VWSCoronaDashboard,
VWSCoronaDashboard1,
VWSCoronaDashboard4 and
VWSCoronaDashboard8
VWSCoronaDashboard4
approved these changes
Jan 20, 2021
VWSCoronaDashboard1
approved these changes
Jan 20, 2021
VWSCoronaDashboard8
approved these changes
Jan 20, 2021
| @@ -0,0 +1,16 @@ | |||
| /** | |||
There was a problem hiding this comment.
nit; I suggest to place this in /scripts and trigger it with ts-node so you can keep the codebase TS only
|
Closed in favor of #1540 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of libraries should be transpiled for IE11 to fix potential syntax errors. One of the libraries didn't work well with the
next-transpile-moduleslibrary, it cannot handle a package.jsonexportsfield. A fix for now is to manually remove that field in a post-install step.. It's not ideal, but a broken dashboard on IE11 isn't either.