External link icon #239
Merged
External link icon #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeleenSG
requested changes
May 8, 2023
There was a problem hiding this comment.
I do think it would be best to add external link as a separate component. That way manon will not override any initial values if it isn't being used.
You can add a new scss-file "link-external" accompanied by a variables file "link-external-variables" for example. And add any external link css there. This will give users the option to include this component or not.
ricklambrechts
force-pushed
the
external-link-icon
branch
from
d78d5a5
to
90a986b
Compare
ricklambrechts
commented
May 8, 2023
HeleenSG
approved these changes
May 8, 2023
HeleenSG
pushed a commit
that referenced
this pull request
May 9, 2023
* Added link external icon * Add external link to documentation * Updated variables in link table * Seperated external link icon to new component * Update manon/link-external-variables.scss
HeleenSG
pushed a commit
that referenced
this pull request
May 9, 2023
* Added link external icon * Add external link to documentation * Updated variables in link table * Seperated external link icon to new component * Update manon/link-external-variables.scss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this it is possible to set an icon for an external link.
Example link: