-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External link icon #239
External link icon #239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think it would be best to add external link as a separate component. That way manon will not override any initial values if it isn't being used.
You can add a new scss-file "link-external" accompanied by a variables file "link-external-variables" for example. And add any external link css there. This will give users the option to include this component or not.
d78d5a5
to
90a986b
Compare
* Added link external icon * Add external link to documentation * Updated variables in link table * Seperated external link icon to new component * Update manon/link-external-variables.scss
* Added link external icon * Add external link to documentation * Updated variables in link table * Seperated external link icon to new component * Update manon/link-external-variables.scss
With this it is possible to set an icon for an external link.
Example link: