feat: sortable table #391
Draft
feat: sortable table #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underdarknl
reviewed
Oct 10, 2023
Co-authored-by: Rick Lambrechts <rick@rl-webdiensten.nl>
ppvg
force-pushed
the
feat/sortable-table
branch
from
bdc08b1
to
79f4759
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes an improved sortable table and implements an interactive example. N.B.: the example implementation is purely demonstrative and not meant to be used by consumers of Manon, as sortable data is quite context-sensitive.
The approach in this PR turns out to match up with the ARIA APG Sortable Table Example.
Things yet to consider and possibly address in the docs:
margin-leftto the<th>button to ensure its text aligns with table cell text.aria-liveregion to announce e.g. "table sorted bycolumnascending/descending".I've published an interactive demo of this approach here: https://sortable-table-demo.netlify.app/.