VVV linting for the win

miohtama · May 12, 2012 · 87e81fe · 87e81fe
1 parent c98db5b
commit 87e81fe
Show file tree

Hide file tree

Showing 41 changed files with 95 additions and 61 deletions.
diff --git a/demos/background-data.js b/demos/background-data.js
@@ -1,3 +1,4 @@
+/*global jQuery, document, setTimeout, console, $ */
 var backgroundData = [
         {
                 "id" : "plain-white",

diff --git a/demos/backgrounds.js b/demos/backgrounds.js
@@ -2,7 +2,7 @@
 
 "use strict";
 
-/*global require, krusovice, window, console, $, document*/
+/*global require, krusovice, window, console, document, jQuery, setTimeout, $ */
 
 /**
  *

diff --git a/demos/canvas.js b/demos/canvas.js
@@ -1,6 +1,6 @@
 "use strict";
 
-/*global require, krusovice, window, console, $, document*/
+/*global require, krusovice, window, console, document, jQuery, setTimeout, $ */
 
 /**
  * Test different <canvas> sizes for the show rendering.

diff --git a/demos/effect-browser.js b/demos/effect-browser.js
@@ -1,3 +1,4 @@
+/*global require, window, jQuery, document, setTimeout, console, $, krusovice */
 "use strict";
 
 /**
@@ -68,15 +69,16 @@ var effectbrowser = {
         lines.forEach(function(l) {
             l = l.trim();
             console.log("Got line:" + l);
+            var copy;
 
-            if(l != "") {
+            if(l !== "") {
 
                 if(l.indexOf(".jpg") >= 0) {
-                    var copy = $.extend({}, baseelem);
+                    copy = $.extend({}, baseelem);
                     copy.imageURL = l;
                     baseplan.push(copy);
                 } else {
-                    var copy = $.extend({}, baseelem);
+                    copy = $.extend({}, baseelem);
                     copy.type = "text";
                     copy.texts = { text : l };
                     copy.shape = "clear";
@@ -102,7 +104,7 @@ var effectbrowser = {
             },
 
             onScreen : {
-                type : $("#onscreen option:selected").val() || "zoomfar",
+                type : $("#onscreen option:selected").val() || "zoomfar"
             }
 
         };
@@ -269,13 +271,13 @@ var effectbrowser = {
             defaultName = "Random";
         }
 
-        var elems = [{id:defaultId, name:defaultName}]
+        var elems = [{id:defaultId, name:defaultName}];
         $.merge(elems, data);
 
         elems.forEach(function(e) {
             var selected="";
             if(e.id == defaults[id.substring(1)]) {
-                selected="selected"
+                selected="selected";
             }
             sel.append("<option " + selected + " value='" + e.id + "'>" + e.name + "</option>");
         });
@@ -344,6 +346,8 @@ var effectbrowser = {
 
         function switchSong(song) {
 
+            /*jshint validthis:true*/
+
             if(!song) {
                 throw "Who turned off the music?";
             }
@@ -403,7 +407,7 @@ var effectbrowser = {
         $("#create-json").click($.proxy(this.outputJSON, this));
     }
 
-}
+};
 
 
 require(["krusovice/api", "../src/thirdparty/domready!"], function(krusovice) {

diff --git a/demos/horizontal-and-vertical.js b/demos/horizontal-and-vertical.js
@@ -1,10 +1,13 @@
-"using strict";
+/*global jQuery, document, setTimeout, console, $ */
 
 /**
  * Test show with one portrait and one landscape image.
  */
 function getHorizontalAndVerticalDesign() {
 
+    "use strict";
+
+
     // Create a show with two elements
     var horizontalAndVerticalPlan = [
             {

diff --git a/demos/song-data.js b/demos/song-data.js
@@ -1,3 +1,7 @@
+/*global jQuery, document, setTimeout, console, $ */
+
+"use strict";
+
 var songData = [
 
         {
@@ -9,4 +13,4 @@ var songData = [
                 "license" : "Creative Commons",
                 "categories" : ["Test"]
         }
-]
+];
diff --git a/demos/text.js b/demos/text.js
@@ -1,6 +1,6 @@
 "use strict";
 
-/*global require,krusovice,window*/
+/*global require, krusovice, window, jQuery, document, setTimeout, console, $ */
 
 /**
  * Test different text outputs

diff --git a/src/api.js b/src/api.js
@@ -1,4 +1,4 @@
-/*global define,window*/
+/*global define, window, console, jQuery, document, setTimeout */
 
 define("krusovice/api", [
 
@@ -44,6 +44,9 @@ define("krusovice/api", [
     //"krusovice/thirdparty/three-extra/BloomPass"
 
 ], function(require, $, THREE, krusovice) {
+
+    "use strict";
+
     console.log("Krusovice API init");
     window.krusovice = krusovice;
     return krusovice;

diff --git a/src/backgrounds.js b/src/backgrounds.js
@@ -3,7 +3,7 @@
  *
  */
 
-/*global define*/
+/*global define, console, jQuery, document, setTimeout */
 
 define("krusovice/backgrounds", ["krusovice/thirdparty/jquery-bundle",
 "krusovice/core",

diff --git a/src/backgrounds/plain.js b/src/backgrounds/plain.js
@@ -4,10 +4,12 @@
  * Scroll & rotate inside a bigger continuous 2D texture.
  */
 
-/*global define*/
+/*global define, console, jQuery, document, setTimeout */
 
 define("krusovice/backgrounds/plain", ["krusovice/thirdparty/jquery-bundle", "krusovice/core", "krusovice/backgrounds"], function($, krusovice, backgrounds) {
 
+"use strict";
+
 /**
  * Single color background
  */

diff --git a/src/backgrounds/scroll2d.js b/src/backgrounds/scroll2d.js
@@ -4,10 +4,12 @@
  * Scroll & rotate inside a bigger continuous 2D texture.
  */
 
-/*global define*/
+/*global define, console, jQuery, document, setTimeout */
 
 define("krusovice/backgrounds/scroll2d", ["krusovice/thirdparty/jquery-bundle", "krusovice/core", "krusovice/backgrounds"], function($, krusovice, backgrounds) {
 
+"use strict";
+
 backgrounds.Scroll2D = function(options, data) {
     this.data = data;
     this.options = options;

diff --git a/src/backgrounds/video.js b/src/backgrounds/video.js
@@ -1,3 +1,5 @@
+/*global console, jQuery, document, setTimeout */
+
 /*
 (function() {
     "use strict";

diff --git a/src/core.js b/src/core.js
@@ -1,8 +1,11 @@
-/*global define,window*/
+/*global define, window, console, jQuery, document, setTimeout */
 
 /* Define krusovice global namespace (from time before require.js) */
 
 define("krusovice/core", [], function() {
+
+    "use strict";
+
     var krusovice = window.krusovice || {};
     return krusovice;
 });
diff --git a/src/design.js b/src/design.js
@@ -1,4 +1,4 @@
-/*global define,window, console*/
+/*global define, window, console, jQuery, document, setTimeout */
 define("krusovice/design", ["krusovice/thirdparty/jquery-bundle", "krusovice/core"], function($, krusovice) {
 'use strict';
 

diff --git a/src/editdata.js b/src/editdata.js
@@ -1,4 +1,4 @@
-/*global define,window,console*/
+/*global define, window, console, jQuery, document, setTimeout */
 
 define("krusovice/editdata", ["krusovice/thirdparty/jquery-bundle", "krusovice/core"], function($, krusovice) {
 'use strict';

diff --git a/src/effects.js b/src/effects.js
@@ -1,4 +1,4 @@
-/*global define*/
+/*global define, console, jQuery, document, setTimeout */
 
 define("krusovice/effects", ['krusovice/thirdparty/jquery-bundle', "krusovice/core", "krusovice/utils"], function($, krusovice, utils) {
 "use strict";

diff --git a/src/effects/linear.js b/src/effects/linear.js
@@ -1,4 +1,4 @@
-/*global define*/
+/*global define, console, jQuery, document, setTimeout */
 
 define("krusovice/effects/linear",
     ["krusovice/thirdparty/jquery-bundle",
@@ -8,7 +8,7 @@ define("krusovice/effects/linear",
      ], function($, krusovice, effects, THREE) {
 "use strict";
 
-/*global krusovice,window,THREE*/
+/*global krusovice, window, THREE, console, jQuery, document, setTimeout */
 
 /**
  *
@@ -248,8 +248,8 @@ effects.SlightMove = $.extend(true, {}, effects.Interpolate, {
         var y = krusovice.utils.splitrnd(r) * effects.ON_SCREEN_MAX_Y;
         this.parameters.sourceVariation.position = [x, y, 0];
 
-        var x = krusovice.utils.splitrnd(r) * effects.ON_SCREEN_MAX_X;
-        var y = krusovice.utils.splitrnd(r) * effects.ON_SCREEN_MAX_Y;
+        x = krusovice.utils.splitrnd(r) * effects.ON_SCREEN_MAX_X;
+        y = krusovice.utils.splitrnd(r) * effects.ON_SCREEN_MAX_Y;
         this.parameters.targetVariation.position = [x, y, 0];
     }
 
@@ -493,7 +493,7 @@ effects.Flip = $.extend(true, {}, effects.QuaternionRotate, {
         p.target.axis = [0,0,0];
         p.targetVariation.axis = [0,0,0];
         p.target.angle = 0;
-    },
+    }
 
 });
 

diff --git a/src/inputelement.js b/src/inputelement.js
@@ -1,4 +1,4 @@
-/*global define,window,console*/
+/*global define, window, console, jQuery, document, setTimeout */
 
 define("krusovice/inputelement", ["krusovice/thirdparty/jquery-bundle", "krusovice/core"], function($, krusovice) {
 'use strict';

diff --git a/src/loader.js b/src/loader.js
@@ -1,4 +1,4 @@
-/*global define,window,console*/
+/*global define, window, console, jQuery, document, setTimeout, Image */
 
 define("krusovice/loader", ["krusovice/thirdparty/jquery-bundle", "krusovice/core"], function($, krusovice) {
 "use strict";

diff --git a/src/music.js b/src/music.js
@@ -1,4 +1,4 @@
-/*global define,window*/
+/*global define, window, console, jQuery, document, setTimeout */
 
 define("krusovice/music", ["krusovice/thirdparty/jquery-bundle", "krusovice/core", "krusovice/utils"], function($, krusovice, utils) {
 "use strict";
@@ -91,7 +91,7 @@ krusovice.music.Registry = $.extend(true, {}, utils.Registry, {
      *
      * @param {Object} audio HTMLAudio element used for music playback, or null if only to load rhytm data
      *
-     * @param {Function} callback(songURL, rhytmhURL, rhytmData) called when all done
+     * @param {Function} callback(songURL, rhytmhURL, rhytmData) called when all done
      *
      * @param {boolean} prelisten Load low quality audio version
      *

diff --git a/src/project.js b/src/project.js
@@ -1,4 +1,4 @@
-/*global define*/
+/*global define, console, jQuery, document, setTimeout */
 
 define("krusovice/project", ["krusovice/thirdparty/jquery-bundle", "krusovice/core"], function($, krusovice) {
     'use strict';

diff --git a/src/quickplay.js b/src/quickplay.js
@@ -6,14 +6,14 @@
  * This is not part of the API bundle, but must be loaded separately using require.js.
  */
 
-/*global define*/
+/*global define, console, jQuery, document, setTimeout */
 define("krusovice/quickplay", ["krusovice/thirdparty/jquery-bundle", "krusovice/api"], function($, krusovice) {
     "use strict";
 
 
     function setupFadeOut(show, audio, fadeOutThreshold) {
 
-        fadeOutThreshold = fadeOutThreshold || 3.0;
+        fadeOutThreshold = fadeOutThreshold || 3.0;
         var duration = show.getDuration();
         var nearEnd = duration - fadeOutThreshold;
 

diff --git a/src/renderers/three.js b/src/renderers/three.js
@@ -1,4 +1,4 @@
-/*global define*/
+/*global define, console, jQuery, document, setTimeout */
 
 define("krusovice/renderers/three", ["krusovice/thirdparty/jquery-bundle", "krusovice/core", "krusovice/thirdparty/three-bundle"], function($, krusovice, THREE) {
 'use strict';

diff --git a/src/rhythmanalysis.js b/src/rhythmanalysis.js
@@ -6,7 +6,7 @@
  *
  */
 
-/*global define,window,console*/
+/*global define, window, console, jQuery, document, setTimeout */
 
 define("krusovice/rhythmanalysis", ["krusovice/thirdparty/jquery-bundle", "krusovice/core"], function($, krusovice) {
 "use strict";

diff --git a/src/show.js b/src/show.js
@@ -1,4 +1,4 @@
-/*global define*/
+/*global define, console, jQuery, document, setTimeout, setInterval, clearInterval */
 define("krusovice/show", ["krusovice/thirdparty/jquery-bundle", "krusovice/core"], function($, krusovice) {
 "use strict";
 

diff --git a/src/showobjects.js b/src/showobjects.js
@@ -1,4 +1,4 @@
-/*global define*/
+/*global define, console, jQuery, document, setTimeout */
 
 define("krusovice/showobjects", ["krusovice/thirdparty/jquery-bundle", "krusovice/core"], function($, krusovice) {
 'use strict';
@@ -34,12 +34,12 @@ krusovice.showobjects.Base = function(cfg) {
 krusovice.showobjects.Base.prototype = {
 
     /**
-     * @cfg {krusovice.Show} Rendering backend used to create artsy
+     * @cfg {krusovice.Show} Rendering backend used to create artsy
      */
     renderer : null,
 
     /**
-     * @cfg {krusovice.TimelineElement} data TimelineElement of play parameters
+     * @cfg {krusovice.TimelineElement} data TimelineElement of play parameters
      */
     data : null,
 
@@ -55,7 +55,7 @@ krusovice.showobjects.Base.prototype = {
     effectObject : null,
 
     /**
-     * @cfg {Function} Function which is called when async prepare() is ready.
+     * @cfg {Function} Function which is called when async prepare() is ready.
      *
      * prepareCallback(success, msg). If success is false delegate the error message.
      */

diff --git a/src/showobjects/framedimage.js b/src/showobjects/framedimage.js
@@ -5,7 +5,7 @@ define("krusovice/showobjects/framedimage", ["krusovice/thirdparty/jquery-bundle
 
 "use strict";
 
-/*global krusovice,window,$,console,THREE*/
+/*global krusovice, window, console, THREE, jQuery, document, setTimeout, Image */
 
 /**
  *
@@ -36,9 +36,9 @@ $.extend(krusovice.showobjects.FramedAndLabeledPhoto.prototype, {
      *
      * Draw borders around the image.
      *
-     * @param {Number} width Canvas width for which we prepare (downscale)
+     * @param {Number} width Canvas width for which we prepare (downscale)
      *
-     * @param {Number} height Canvas width for which we prepare (downscale)
+     * @param {Number} height Canvas width for which we prepare (downscale)
      */
     prepare : function(loader, width, height) {
 
@@ -248,7 +248,7 @@ $.extend(krusovice.showobjects.FramedAndLabeledPhoto.prototype, {
         var mat = new THREE.ShaderMaterial({
           uniforms: uniforms,
           vertexShader: shader.vertexShader,
-          fragmentShader: shader.fragmentShader,
+          fragmentShader: shader.fragmentShader
           //blending: THREE.NormalBlending,
           //transparent : true,
           //opacity : 0.5

diff --git a/src/showobjects/text.js b/src/showobjects/text.js
@@ -4,7 +4,7 @@
  *
  */
 
-/*global window,$,console,define*/
+/*global window, console, define, jQuery, document, setTimeout, Image */
 
 define("krusovice/showobjects/text", ["krusovice/thirdparty/jquery-bundle",
     "krusovice/core",

diff --git a/src/showobjects/textdefinitions.js b/src/showobjects/textdefinitions.js
@@ -1,4 +1,4 @@
-/*global define*/
+/*global define, console, jQuery, document, setTimeout */
 
 
 /**