Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplicated fields when embedding #1

Merged
merged 1 commit into from Jul 24, 2019
Merged

Avoid duplicated fields when embedding #1

merged 1 commit into from Jul 24, 2019

Conversation

gaul
Copy link
Contributor

@gaul gaul commented Jan 13, 2017 •
edited

Previously the embedded fields were not used and methods were
unnecessarily overridden.

@gaul gaul changed the title Avoid duplicated field when embedding Avoid duplicated fields when embedding Jan 13, 2017
@gaul
Avoid duplicated fields when embedding
bdee252 
Previously the embedded fields were not used and methods were
unnecessarily overridden.
@gaul
Copy link
Contributor Author

gaul commented Apr 10, 2018

@miolini Rebased. Anything blocking merging this commit?

@gaul
Copy link
Contributor Author

gaul commented Jul 23, 2019

@miolini bump

@miolini miolini merged commit aa48df3 into miolini:master Jul 24, 2019
@miolini
Copy link
Owner

miolini commented Jul 24, 2019

Thank you!

@gaul gaul deleted the embedding branch July 24, 2019 03:46
@davidnewhall davidnewhall mentioned this pull request Jul 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaul @miolini