Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 修改 link 校验规则 #20

Merged
merged 28 commits into from Jan 25, 2018
Merged

Conversation

wupengFEX
Copy link
Member

@wupengFEX wupengFEX commented Jan 8, 2018

  • link

    • 强校验 mip.css,页面中必须存在;
    • 去掉 standardhtml 属性限制;
    • 去掉包含 ala 的 path;
    • 校验 mip.css 路径,之前的没有转义.号,同时没有强校验 mip.css 地址,导致可能出现c-mipcdn-com或非 mip.css;
    • 优化不能重复的属性标签,canonical,miphtml属性标记的link不能重复;
  • script

    • 强校验 mip.js,页面中必须存在;
    • 去掉 ala 的 path;
    • 校验 mip.js 路径,之前的没有转义.号,同时没有强校验 mip.js 地址,导致可能出现c-mipcdn-com或非 mip.js;
    • 优化部分正则,去掉重复校验的部分;
  • mip-form

    • method 严格校验,否则会出现 geta,post 等类型的属性;
  • meta

    • 严格校验 charset uft-8
  • source

    • 使其父元素可以是 picture,mip-video,mip-audio;
  • mip-img

    • 必须存在 src 或 srcset 中的一个属性;
  • base

    • base 必须存在 target 或 href 属性;
    • 只能存在与 head 中;
    • 只能出现一次;

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.319% when pulling 6db132b on wupengFEX:difference into 4a3f5e3 on mipengine:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.319% when pulling 8b31d7d on wupengFEX:difference into 4a3f5e3 on mipengine:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.319% when pulling 1aba77f on wupengFEX:difference into 4a3f5e3 on mipengine:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.319% when pulling 806c028 on wupengFEX:difference into 4a3f5e3 on mipengine:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0009%) to 99.32% when pulling 098912a on wupengFEX:difference into 4a3f5e3 on mipengine:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 99.321% when pulling 7ca9468 on wupengFEX:difference into 4a3f5e3 on mipengine:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 99.321% when pulling 80ed540 on wupengFEX:difference into 4a3f5e3 on mipengine:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 99.321% when pulling 319a49c on wupengFEX:difference into 4a3f5e3 on mipengine:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 98.837% when pulling a7a4d7f on wupengFEX:difference into 4a3f5e3 on mipengine:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 98.837% when pulling bf86756 on wupengFEX:difference into 4a3f5e3 on mipengine:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 98.837% when pulling bdb6922 on wupengFEX:difference into 4a3f5e3 on mipengine:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 98.837% when pulling d60360b on wupengFEX:difference into 4a3f5e3 on mipengine:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 98.837% when pulling b0dbcf9 on wupengFEX:difference into 4a3f5e3 on mipengine:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 98.837% when pulling ffd6c85 on wupengFEX:difference into 4a3f5e3 on mipengine:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 98.837% when pulling ffd6c85 on wupengFEX:difference into 4a3f5e3 on mipengine:master.

@harttle
Copy link
Member

harttle commented Jan 11, 2018

我们在 npm test 里加一个 test:e2e 吧!跑 cases/ 下的 case,这样以后改规则就不会忘了更新了

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 98.837% when pulling b603fa2 on wupengFEX:difference into 4a3f5e3 on mipengine:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 98.837% when pulling a51e168 on wupengFEX:difference into 4a3f5e3 on mipengine:master.

@coveralls
Copy link

coveralls commented Jan 19, 2018

Coverage Status

Coverage increased (+0.04%) to 99.354% when pulling f14014f on wupengFEX:difference into 4a3f5e3 on mipengine:master.

@wupengFEX wupengFEX merged commit 0325b0c into mipengine:master Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants