Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 组件新增生命周期 viewportCallback #403

Merged
merged 3 commits into from Dec 18, 2018

Conversation

yenshih
Copy link
Contributor

@yenshih yenshih commented Dec 10, 2018

相关 ISSUE: #390

1、升级点

  • Vue 组件新增生命周期 viewportCallback

2、影响范围

  • 新增功能,无影响

3、自测 Checklist

  • mip2-extensions 中 mip-link mip-tabs mip-toast 等 Vue 组件,在页面上同时存在数十个组件滚动时,viewportCallback 正确调用
  • 在 Vue 组件中新增
export default {
  // ...
  viewportCallback (inViewport) {
    console.log(inViewport)
  },
  // ...
}

页面滚动时,可以在控制台观察组件调用 viewportCallback 的情况

4、需要覆盖的场景和 Case

  • 是否覆盖了 sf 打开 MIP 页
  • 是否验证了极速服务 MIP 页面效果

5、自测机型和浏览器

  • 是否覆盖了 iOS 系统手机
  • 是否覆盖了 Android 系统手机
  • 是否覆盖了 iPhone 版式浏览器(比如 QQ、UC、Chrome、Safari、安卓自带浏览器)
  • 是否覆盖了手百

@coveralls
Copy link

coveralls commented Dec 10, 2018

Pull Request Test Coverage Report for Build 769

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0009%) to 94.949%

Totals Coverage Status
Change from base Build 783: 0.0009%
Covered Lines: 3574
Relevant Lines: 3686

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 728

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0009%) to 94.815%

Totals Coverage Status
Change from base Build 712: 0.0009%
Covered Lines: 3557
Relevant Lines: 3674

💛 - Coveralls

@PengXing PengXing closed this Dec 10, 2018
@PengXing PengXing reopened this Dec 10, 2018
@huanghuiquan huanghuiquan merged commit 61d87a7 into dev Dec 18, 2018
huanghuiquan pushed a commit that referenced this pull request Dec 18, 2018
* feat: Add viewportCallback lifecycle

* fix: typo
@yenshih yenshih deleted the dev-viewport-callback branch December 25, 2018 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants