Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【免测】 mip-img 加载成功后触发 load 事件 #422

Merged
merged 2 commits into from
Dec 20, 2018

Conversation

yenshih
Copy link
Contributor

@yenshih yenshih commented Dec 18, 2018

相关 ISSUE: #421

1、升级点

  • mip-img 加载后触发 load 事件

2、影响范围

  • 线上无影响,只在图片加载后额外触发一个事件

3、自测 Checklist

  • /examples/builtin-components/mip-img.html 中加入下面的代码,事件监听正常
<script>
  document.querySelectorAll('mip-img').forEach(img => MIP.util.event.listen(img, 'load', () => console.log('load')))
</script>

4、需要覆盖的场景和 Case

  • 是否覆盖了 sf 打开 MIP 页
  • 是否验证了极速服务 MIP 页面效果

5、自测机型和浏览器

  • 是否覆盖了 iOS 系统手机
  • 是否覆盖了 Android 系统手机
  • 是否覆盖了 iPhone 版式浏览器(比如 QQ、UC、Chrome、Safari、安卓自带浏览器)
  • 是否覆盖了手百

@coveralls
Copy link

coveralls commented Dec 18, 2018

Pull Request Test Coverage Report for Build 779

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0009%) to 94.95%

Totals Coverage Status
Change from base Build 776: 0.0009%
Covered Lines: 3575
Relevant Lines: 3687

💛 - Coveralls

@yenshih yenshih changed the title mip-img 加载成功后触发 load 事件 [免测] mip-img 加载成功后触发 load 事件 Dec 20, 2018
@gaoshan003
Copy link

确认免测

@yenshih yenshih changed the title [免测] mip-img 加载成功后触发 load 事件 【免测】 mip-img 加载成功后触发 load 事件 Dec 20, 2018
@yenshih yenshih merged commit 22b959f into dev Dec 20, 2018
@yenshih yenshih deleted the dev-421-img-onload branch December 20, 2018 07:11
craigchencc pushed a commit that referenced this pull request Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants