Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade AutoDiff support of trigonometric ops, also fix some problems with MstAlgebra #140

Merged
merged 5 commits into from
Sep 20, 2020
Merged

Upgrade AutoDiff support of trigonometric ops, also fix some problems with MstAlgebra #140

merged 5 commits into from
Sep 20, 2020

Conversation

CommanderTvis
Copy link
Collaborator

No description provided.

@CommanderTvis CommanderTvis added bug Something isn't working feature A new feature request labels Sep 20, 2020
@CommanderTvis CommanderTvis added this to the 0.2 milestone Sep 20, 2020
altavir
altavir requested changes Sep 20, 2020
View reviewed changes
Copy link
Member

@altavir altavir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests.

@altavir
Copy link
Member

altavir commented Sep 20, 2020

And append the changelog.

altavir
altavir approved these changes Sep 20, 2020
View reviewed changes
Copy link
Member

@altavir altavir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@altavir altavir merged commit 51b7d4e into dev Sep 20, 2020
@CommanderTvis CommanderTvis deleted the autodiff-update branch September 21, 2020 11:39
@altavir altavir mentioned this pull request Jan 20, 2021
Merged
@altavir altavir mentioned this pull request Feb 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altavir altavir altavir approved these changes

Assignees
No one assigned
Labels
bug Something isn't working feature A new feature request
Projects
None yet
Milestone
0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@CommanderTvis @altavir