[WIP] Adding annotations.Tags and reformatting to_jams #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #540 and #541. ccing @bmcfee
While looking at the
to_jamsfunctions I realized that they are unnecessarily complicated to accommodateSalamimulti-annotator schema. I'm going to simplify theto_jamsconverters so they don't expect the list of tuples anymore (which will simplifyjams_utilsa lot) and will address the multi-annotator of Salami using #515 and mirroring this PR from Soundata.@rabitt check if I'm not duplicating work or stepping on your #545.