Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating file paths and other issues with windows environment #567

Merged

Conversation

harshpalan
Copy link
Collaborator

Creating a PR to update issues with test cases and other files while building for the Windows environment.

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #567 (1cbdbf4) into master (4b67c85) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #567   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files          54       54           
  Lines        6619     6620    +1     
=======================================
+ Hits         6408     6409    +1     
  Misses        211      211           

@harshpalan harshpalan added bug Something isn't working tests changes to tests labels Nov 22, 2022
@harshpalan harshpalan changed the title [WIP] Updating file paths and other issues with windows [WIP] Updating file paths and other issues with windows environment Nov 22, 2022
@magdalenafuentes magdalenafuentes mentioned this pull request Nov 23, 2022
13 tasks
Copy link
Collaborator

@magdalenafuentes magdalenafuentes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshpalan I know you're finishing this up, but fantastic job so far!

See my comments and let me know if anything's not clear

mirdata/datasets/compmusic_jingju_acappella.py Outdated Show resolved Hide resolved
mirdata/datasets/compmusic_jingju_acappella.py Outdated Show resolved Hide resolved
mirdata/datasets/saraga_hindustani.py Outdated Show resolved Hide resolved
tests/datasets/test_dali.py Outdated Show resolved Hide resolved
tests/datasets/test_haydn_op20.py Outdated Show resolved Hide resolved
tests/datasets/test_openmic2018.py Show resolved Hide resolved
tests/test_io.py Show resolved Hide resolved
@harshpalan harshpalan marked this pull request as ready for review November 23, 2022 21:07
@harshpalan harshpalan changed the title [WIP] Updating file paths and other issues with windows environment Updating file paths and other issues with windows environment Nov 23, 2022
Copy link
Collaborator

@magdalenafuentes magdalenafuentes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic job @harshpalan 🎉

Feel free to merge this!

@harshpalan harshpalan merged commit 02cd5c0 into mir-dataset-loaders:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests changes to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants