Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_std_in_bound() method from OTF could be moved to a new file #30

Closed
stevetorr opened this issue Sep 12, 2019 · 1 comment
Closed

is_std_in_bound() method from OTF could be moved to a new file #30

stevetorr opened this issue Sep 12, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@stevetorr
Copy link
Contributor

Related to issue 14: #14

Because the is_std_in_bound() function is a convenience method for OTF or (the in development) TrajectoryTrainer, it would eliminate redundancy to have it exist outside of the OTF class. If we end up splitting predict functions to a separate file, I think that this function would be a natural fit for there (given that it is to diagnose the result of a prediction on a structure).
@stevetorr stevetorr added the enhancement New feature or request label Sep 12, 2019
@jonpvandermause jonpvandermause mentioned this issue Sep 27, 2019
Merged
@YuuuXie
Copy link
Collaborator

YuuuXie commented Oct 12, 2019

close via pull request #77

@YuuuXie YuuuXie closed this as completed Oct 12, 2019
anjohan pushed a commit that referenced this issue Jan 20, 2022
@YuuuXie
Merge pull request #30 from mir-group/linear_map
e06d342 
Power=1 linear model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevetorr @YuuuXie