-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development #303
Merged
Merged
Development #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SGP calculator & lammps variance multi-cutoff
Single atom energy dict for issue #326
1.3.1 Bug fixings - stress, pair_style cutsq, offline preprocess, sanity check
1.3.2 Non normalized dot product kernel
1.3.3 Relative noise for each training data point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The major changes of this pull request includes
(see
flare/examples
for the format and parameters for yaml)Code rearrangement
Following the arrangement in the figure below (also in the README), the modules are rearranged
In the
flare
folder, we now haveFLARE_Atoms
module, to replace struc.pyIn the root directory, we now have files and folders from flare++ including
Code removal
Modules that are kept in version < 1.0.0, but not in version >= 1.0.0
flare_io
is replaced by ASE's ioutils/element_coder.py
converts chemical symbols to atomic numbers, and can be replaced by functions in ASEflare/lammps
can be replaced by ASE lammps calculatorlearning_protocal.py
not used or testedmd.py
,dft_interface
folder,utils/md_helper.py
ase/otf.py
intootf.py
ase/dft.py
Remove corresponding unit tests and test_files
test_files
folder:test_files
, and match the current new OTF output with them in unit test.Code addition
LAMMPS_MOD
inflare/ase/lammps.py
, such that the same syntax can be used as this example on ASE web, and additionally supportscompute
,region
,dump
and otherfix
such asnvt
in the parameter dict.LAMMPS_MD
inflare/ase/lammps.py
is a child class of ASEMolecularDynamics
which can be used inOTF
withmd_engine = "PyLAMMPS"
, such that the MD in OTF is done by LAMMPS. Both non-mapped and mapped variances are supported. This serves as a simple version (flightning) of LAMMPS OTF while the lammps is called from python, and the lammps commands are only limited to those supported byLAMMPS_MOD
. For more complete version, wait until Anders merges the lmp_otf branch.FakeMD
andFakeDFT
inflare/md/fake.py
are used for offline training withOTF
code by settingmd_engine="Fake"
, which provides a less advanced version of GPFA. Basically we provide an AIMD trajectory to it, and during OTF, it will run a fake md by giving the next frame from the provided trajectory instead of a real MD step. AndFakeDFT
will give forces of the current frame directly from the provided trajectory instead of a real DFT code.flare/scripts
is used for training yaml configuration. After pip installation, the users doflare-otf config.yaml
to launch OTF training.test_sparse_gp.py
,test_parse.py
andtest_lammps.py
are merged from flare++test_sgp_otf.py
is for sparse GP with OTF training. It also tests that the OTF with ASEVelocityVerlet
has trajectory matching exactly withLAMMPS
MD usingfix/nve
test_fake_otf.py
tests OTF training for fake MDexamples
for unit testsStaled issues to close
close #24, close #124: in-house MD code has been replaced by ASE MD
close #41, close #116, close #129: in-house DFT interfaces have been replaced by ASE calculators
close #58: the DFT frames from OTF are saved into an .xyz file, in the
PyLAMMPS
MD mode, the MD trajectory is saved into an .xyz file. While other information like hyper parameters are still saved in the .out file without need for formatting.Dependencies
struc.py
andvasp_utils.py
that have been replacedTODO (if any)
Checklist
Work-in-progress pull requests are encouraged, but please put [WIP]
in the pull request title.
Before a pull request can be merged, the following items must be checked:
Run Black on your local machine.
setup.py
is updated. We are using a version number format a.b.cNote that the CI system will run all the above checks. But it will be much more
efficient if you already fix most errors prior to submitting the PR.