New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditional recursive verifier #758
Conversation
let ProofWithPublicInputsTarget { | ||
proof: | ||
ProofTarget { | ||
wires_cap: dummy_wires_cap, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Let's not call it a dummy proof since were called proof 1 / proof 2 in the param names. And arguably the method is more general; seems like it could theoreticaly be used to verify either of two nontrivial circuits, in some particular cases where the two circuits happen to have the same size, gates, etc.
cap0.0 | ||
.into_iter() | ||
.zip_eq(cap1.0) | ||
.map(|(h0, h1)| HashOutTarget { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: may be nice to have a select_hash
since it comes up in a couple places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Maybe as a next step we can have a conditional recursion function which only takes one inner circuit, and generates a dummy circuit automatically?
No description provided.