Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker App for chatgpt history GUI #21

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ab-almahfadi
Copy link

Hello there,

Hope you are doing well,

I am glad to share my changes with you. I developed your app in the docker app and made some changed hope you find that good.

Thank you,

@kuchin
Copy link
Contributor

kuchin commented Oct 9, 2023

Hey. I'm glad you made the docker version. Unfortunately I cannot accept your changes as-is, I would ask you to make certain changes first, before I can accept. Let me know if you're interested.

@ab-almahfadi
Copy link
Author

Hello Mr. Kuchin,
I hope you are doing well.
I am delighted to hear from you. Yeah, I am very interesting in modifying what you want to change.

Let's begin

Copy link
Contributor

@kuchin kuchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a bunch of feedback. Please review

Dockerfile Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
app.py Show resolved Hide resolved
app.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
static/index.html Outdated Show resolved Hide resolved
@ab-almahfadi
Copy link
Author

oh sorry for these mistakes and the wrong request for review

I will make the changes then I will send another request

@ab-almahfadi ab-almahfadi marked this pull request as draft October 9, 2023 12:26
@ab-almahfadi ab-almahfadi marked this pull request as ready for review October 10, 2023 14:31
@ab-almahfadi
Copy link
Author

Hello Mr. Kuchin,

I hope you are doing well. I didn't hear from you for a while.

Is there any problems in the modifications? If there are any issue, Please comment what you need to modify in this review request.

Yours Sincerely,
Abdullah

Copy link
Contributor

@kuchin kuchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I disagree with most of your responses
  • There are still some "empty" changes like in Makefile or static/index.html
  • Templates should go to separate files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants