Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a2po does not support ISO 639-2 language codes #42

Closed
albertvaka opened this issue Nov 30, 2015 · 7 comments
Closed

a2po does not support ISO 639-2 language codes #42

albertvaka opened this issue Nov 30, 2015 · 7 comments

Comments

@albertvaka
Copy link

Since Android 5.0 [1] is now possible to use ISO 639-2 language codes [2] like «ast» for localization files (values-xxx). While trying to import an "ast.po" file using a2po import, I get the following error:

    [failed] ast is not a valid locale

Can you add support for these three-letter language codes?

[1] https://code.google.com/p/android/issues/detail?id=63358
[2] http://www.loc.gov/standards/iso639-2/php/code_list.php

@miracle2k
Copy link
Owner

I won't have time to add this any time soon, but would of course accept a pull request.

@albertvaka
Copy link
Author

It seems to be a limitation in Babel. I opened an issue with them [1], but if it can't be easily fixed there I will submit a PR here to ignore these kind of errors. Would that be okay?

[1] python-babel/babel#285

@miracle2k
Copy link
Owner

If a workaround is possible, sure. I don't know if it is important that we have a Babel instance.

@albertvaka
Copy link
Author

It looks like it's not a but. Installing a newer version of Babel fixed the issue.

Sorry and thank you!

@albertvaka
Copy link
Author

Finally, it looks like the current version of android2po in the pip repo (1.2) depends on an older version of Babel where this is still an issue. Can you make a release of the current git master, so a version without this problem is available through pip?

@albertvaka albertvaka reopened this Dec 2, 2015
@albertvaka
Copy link
Author

@miracle2k Any updates? It would be awesome if you could make a new release :) There have been many changes and fixes since the last version, including the fix for this bug. Thanks a lot for your time!

@miracle2k
Copy link
Owner

I pushed a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants