Make tests run #86
Merged
Make tests run #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests currently don't start on master when running `tox`, erroring with:
```
DEPRECATION: --allow-external has been deprecated and will be removed in the future. Due to changes in the repository protocol, it no longer has any effect.
DEPRECATION: --allow-unverified has been deprecated and will be removed in the future. Due to changes in the repository protocol, it no longer has any effect.
Collecting nose==1.3.7
Using cached nose-1.3.7-py2-none-any.whl
Collecting webassets==dev
Could not find a version that satisfies the requirement webassets==dev (from versions: 0.4, 0.5, 0.6, 0.7, 0.7.1, 0.8, 0.9, 0.10, 0.10.1, 0.11, 0.11.1, 0.12.0)
No matching distribution found for webassets==dev
```
I've removed the deprecated `pip` flags and made the `webassets` dev version install from the Github master via a tarball, assuming that's what it was doing before through the now missing `dev` version on PyPI.
There are still failures in the test suite after this though:
```
======================================================================
FAIL: tests.test_django.TestLoader.test
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/adamj/Documents/Projects/django-assets/.tox/django19-py35/lib/python3.5/site-packages/nose/case.py", line 198, in runTest
self.test(*self.arg)
File "/Users/adamj/Documents/Projects/django-assets/tests/test_django.py", line 192, in test
assert len(bundles) == 1
AssertionError
======================================================================
FAIL: tests.test_django.TestLoader.test_cached_loader
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/adamj/Documents/Projects/django-assets/.tox/django19-py35/lib/python3.5/site-packages/nose/case.py", line 198, in runTest
self.test(*self.arg)
File "/Users/adamj/Documents/Projects/django-assets/tests/test_django.py", line 202, in test_cached_loader
assert len(bundles) == 1
AssertionError
----------------------------------------------------------------------
Ran 19 tests in 0.578s
```
Closed
|
Thanks for the patch! |
miracle2k
added a commit
that referenced
this pull request
Oct 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests currently don't start on master when running
tox, erroring with:I've removed the deprecated
pipflags and made thewebassetsdev version install from the Github master via a tarball, assuming that's what it was doing before through the now missingdevversion on PyPI.There are still failures in the test suite after this though: