make fnmatch.translate also support globstar and make * non-greedy.

[joolswills]

eg

before:

pattern="/home/*/cache"

would match

/home/user/cache
/home/user/something/cache
/home/suer/something/something/cache

now:

pattern="/home/*/cache"

would match

/home/user/cache
/home/user2/cache

but would not match /home/user/something/cache

pattern="/home/**/cache"

would match

/home/user/cache
/home/user/something/cache
/home/suer/something/something/cache

this brings it in line with the other functions in glob2, and although changes the functionality of a single * - makes it match the behaviour of most shells, and is more intuitive.

[miracle2k]

Seems good, thanks.

[miracle2k]

I had to revert this, unfortunately. It causes tests failures, as pointed out by @musically-ut.

I looked at it and it turns out that adding this behaviour to fnmatch like this breaks the glob functionality itself.

The way the glob module is written (probably since the original Python code), it expects fnmatch to allow "*" across / boundaries.

[joolswills]

I shame as it would make sense that this function would include the extended glob feature - what about changing the other code to work with it ?

My change was initially so attic backup could use extended globbing as it uses this function, but I guess it could be included as a custom function within the backup software.

[miracle2k]

I'm open to it in principle, but rather wary about deviating to far from the standard behaviour.

Indeed, a custom copy of fnmatch might be a perfectly feasable solution.

Another possible idea: Glob2 can actually be subclassed to glob not over the actual filesystem, but over a virtual one. See for example:

https://github.com/miracle2k/django-assets/blob/21ddc81feefcabe73e88cedc2fb91b237abbeb0e/django_assets/env.py#L77

It's possible you could use this somehow to get the full matching functionality.

I'm actually interested in attic (borg?) as a backup tool and so I'd be happy if you can make this work.