Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable PNS feature in ffmpeg conversion #359

Closed
tobeehh opened this issue Sep 23, 2022 · 7 comments · Fixed by #409
Closed

Disable PNS feature in ffmpeg conversion #359

tobeehh opened this issue Sep 23, 2022 · 7 comments · Fixed by #409

Comments

@tobeehh
Copy link

tobeehh commented Sep 23, 2022

Hey,

i am trying to go back to 2007 by using my old iPod. Now i realized that the PNS feature of ffmpeg that freyr uses causes a constant squeaking on the ipod. Any chance to implement something to convert without this issue?

For more info see https://www.reddit.com/r/ipod/comments/r2cti3/squeaking_noises_only_through_the_ipod_and_only/

Net info:
Your encoder is using the PNS feature in AAC. This is incompatible with iPods. Use -aac_pns 0 in ffmpeg to encode a file without this feature. I went down a deep rabbit hole, and talked to several ffmpeg developers to discover this.

@tobeehh tobeehh changed the title Diable PNS feature in ffmpeg conversion Disable PNS feature in ffmpeg conversion Sep 23, 2022
@miraclx
Copy link
Owner

miraclx commented Sep 27, 2022

Interesting, have you already explored this fix? Does it work for you?

You can add the argument here:

freyr-js/cli.js

Line 1103 in a52cfbc

await ffmpeg.run(

Once you confirm it works for you, I'll accept a patch.

@tobeehh
Copy link
Author

tobeehh commented Oct 6, 2022

I will try that on the weekend and report back.

@tobeehh
Copy link
Author

tobeehh commented Jan 1, 2023

Works!

@tobeehh
Copy link
Author

tobeehh commented Jan 1, 2023

Can you release a docker variant of the new version as well again?

@miraclx
Copy link
Owner

miraclx commented Jan 4, 2023

Hi @tobeehh, I just created #409, you can use the docker image built to test – freyrcli/freyrjs-git:pr-409.

Once you confirm it works, I'll have it merged, and it'll ship in the next release.

@tobeehh
Copy link
Author

tobeehh commented Jan 13, 2023

Works like a charm! Great for all retro audio lovers! :)

@tthayer
Copy link

tthayer commented Apr 3, 2023

I had installed RockBox to work around this issue. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants