Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Apple Music): update readme & restore custom dev token #624

Merged
merged 5 commits into from
Jan 2, 2024

Conversation

Khadeeejah
Copy link
Contributor

Restores the custom developer token option, in case anyone has utility for that.

Before tokens are stored in the session cache, they are tested to ensure they've both not expired, and Apple Music actually permits it's use.

The use of a valid token in the conf.json overrides the session token.

And an invalid token in conf.json falls back to the session token.

An invalid session token would fallback to pulling it from the Apple Music website.

@@ -1,4 +1,4 @@
<!-- markdownlint-disable MD001 MD007 MD023 MD041 MD051 -->
<!-- markdownlint-disable MD001 MD007 MD023 MD033 MD041 MD051 -->
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

Comment on lines +507 to +510
stackLogger.error(
'\x1b[31m[i]\x1b[0m',
'SHOW_DEBUG_STACK' in process.env ? util.formatWithOptions({colors: true}, err) : err['message'] || err,
);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@miraclx
Copy link
Owner

miraclx commented Jan 2, 2024

Thank you for your contributions!

@miraclx miraclx merged commit 1fe1dfb into miraclx:master Jan 2, 2024
17 of 18 checks passed
@miraclx miraclx mentioned this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants