build(docker): download deps in dedicated Gradle task

miracum · Aug 9, 2021 · 4dfaddb · 4dfaddb
1 parent c30a465
commit 4dfaddb
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 11 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -62,14 +62,14 @@ jobs:
         uses: docker/setup-buildx-action@v1
       - name: Login to GitHub Container Registry
         uses: docker/login-action@v1
-        if: github.event_name != 'pull_request'
+        if: ${{ github.event_name != 'pull_request' }}
         with:
           registry: ghcr.io
           username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}
       - name: Login to MIRACUM Container Registry
         uses: docker/login-action@v1
-        if: github.event_name != 'pull_request'
+        if: ${{ github.event_name != 'pull_request' }}
         with:
           registry: harbor.miracum.org
           username: "robot$miracum-etl+github-actions"
@@ -90,7 +90,7 @@ jobs:
           push: ${{ github.event_name != 'pull_request' }}
           tags: ${{ steps.docker_meta.outputs.tags }}
           labels: ${{ steps.docker_meta.outputs.labels }}
-          load: ${{ github.event_name == 'pull_request' }}
+          # load: ${{ github.event_name == 'pull_request' }}
           platforms: linux/amd64,linux/arm64,linux/arm/v7
       - name: List images
         id: list_images
@@ -102,20 +102,20 @@ jobs:
         env:
           FHIR_GATEWAY_IMAGE_NAME: "${{ steps.list_images.outputs.image_name }}"
         run: |
-          docker-compose -p $GITHUB_JOB-e2e -f deploy/docker-compose.yml -f deploy/docker-compose.gw-deps.yml -f tests/e2e/docker-compose.yml --project-directory=tests/e2e build
-          docker-compose -p $GITHUB_JOB-e2e -f deploy/docker-compose.yml -f deploy/docker-compose.gw-deps.yml -f tests/e2e/docker-compose.yml --project-directory=tests/e2e run gpasinit
-          docker-compose -p $GITHUB_JOB-e2e -f deploy/docker-compose.yml -f deploy/docker-compose.gw-deps.yml -f tests/e2e/docker-compose.yml --project-directory=tests/e2e run tester
+          docker-compose -p "$GITHUB_JOB-e2e" -f deploy/docker-compose.yml -f deploy/docker-compose.gw-deps.yml -f tests/e2e/docker-compose.yml --project-directory=tests/e2e build
+          docker-compose -p "$GITHUB_JOB-e2e" -f deploy/docker-compose.yml -f deploy/docker-compose.gw-deps.yml -f tests/e2e/docker-compose.yml --project-directory=tests/e2e run gpasinit
+          docker-compose -p "$GITHUB_JOB-e2e" -f deploy/docker-compose.yml -f deploy/docker-compose.gw-deps.yml -f tests/e2e/docker-compose.yml --project-directory=tests/e2e run tester
       - name: Print E2E logs
         if: always()
         run: |
-          docker-compose -p $GITHUB_JOB-e2e -f deploy/docker-compose.yml -f deploy/docker-compose.gw-deps.yml -f tests/e2e/docker-compose.yml logs
-          docker-compose -p $GITHUB_JOB-e2e -f deploy/docker-compose.yml -f deploy/docker-compose.gw-deps.yml -f tests/e2e/docker-compose.yml down --volumes --remove-orphans
+          docker-compose -p "$GITHUB_JOB-e2e" -f deploy/docker-compose.yml -f deploy/docker-compose.gw-deps.yml -f tests/e2e/docker-compose.yml logs
+          docker-compose -p "$GITHUB_JOB-e2e" -f deploy/docker-compose.yml -f deploy/docker-compose.gw-deps.yml -f tests/e2e/docker-compose.yml down --volumes --remove-orphans
 
   release:
     needs: build
     name: Release
     runs-on: ubuntu-20.04
-    if: github.event_name != 'pull_request'
+    if: ${{ github.event_name != 'pull_request' }}
     steps:
       - name: Checkout
         uses: actions/checkout@v2

diff --git a/Dockerfile b/Dockerfile
@@ -2,8 +2,11 @@ FROM gradle:7.1-jdk11 AS build
 WORKDIR /home/gradle/src
 ENV GRADLE_USER_HOME /gradle
 
-COPY build.gradle settings.gradle ./
-RUN gradle build || true
+COPY build.gradle gradle.properties settings.gradle ./
+
+# Only download dependencies
+# see https://zwbetz.com/why-is-my-gradle-build-in-docker-so-slow/
+RUN gradle clean build --no-daemon > /dev/null 2>&1 || true
 
 COPY --chown=gradle:gradle . .
 RUN gradle build --info && \