Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a copy function #9

Merged
merged 1 commit into from
Nov 28, 2021
Merged

Add a copy function #9

merged 1 commit into from
Nov 28, 2021

Conversation

bobot
Copy link
Contributor

@bobot bobot commented Nov 24, 2021 

val copy : 'a t -> 'a t
(** [copy t] copies the BF. The fresh BF is completely separated from the
    given one. *)

@bobot bobot force-pushed the add_copy_function branch 3 times, most recently from 3b96329 to 815a1b8 Compare November 24, 2021 12:13
pascutto
pascutto approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@pascutto pascutto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Can you also add an entry to CHANGES.md, under an unreleased title?
I'll fix the packaging issues to make the ocaml-ci happy in a separate PR, then will merge this :)

@pascutto
Copy link
Contributor

Do you need a release with this change?

@bobot
Copy link
Contributor Author

bobot commented Nov 25, 2021

Not immediately, thanks for asking.

@pascutto pascutto merged commit 084961d into mirage:master Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascutto pascutto pascutto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bobot @pascutto