Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dune warning #108

Merged
merged 4 commits into from May 11, 2020
Merged

Fix dune warning #108

merged 4 commits into from May 11, 2020

Conversation

samoht
Copy link
Member

@samoht samoht commented May 11, 2020

Otherwise building the project gives:

$ dune build
File "dune-project", line 3, characters 14-17:
3 | (using menhir 2.0)
                  ^^^
Warning: Version 2.0 of the menhir extension is not supported until version
1.4 of the dune language.
Supported versions of this extension in version 1.2 of the dune language:
- 1.0

@hannesm
Copy link
Member

hannesm commented May 11, 2020

LGTM

@samoht
Copy link
Member Author

samoht commented May 11, 2020

@hannesm is that ok if I make a point release of charrua with just that fix?

@hannesm
Copy link
Member

hannesm commented May 11, 2020

@samoht sure, I'd propose to update all the opam files in this repository to depend on "dune" {>= "1.4.0"}.

@samoht
Copy link
Member Author

samoht commented May 11, 2020

Ok I've add constraints to the dune files and a changelog entry.

@hannesm
Copy link
Member

hannesm commented May 11, 2020

LGTM

@samoht samoht merged commit b514d6a into mirage:master May 11, 2020
samoht added a commit to samoht/opam-repository that referenced this pull request May 11, 2020
…ge, charrua-unix, charrua and charrua-server (1.2.1)

CHANGES:

* Fix minimal dune version (1.4) (mirage/charrua#108 @samoht)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants